From: Ying Xue <ying.xue@windriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <davem@davemloft.net>, <vfalico@redhat.com>,
<john.r.fastabend@intel.com>, <stephen@networkplumber.org>,
<antonio@meshcoding.com>, <dmitry.tarnyagin@lockless.no>,
<socketcan@hartkopp.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 10/10] net: nl80211: __dev_get_by_index instead of dev_get_by_index to find interface
Date: Wed, 15 Jan 2014 09:18:05 +0800 [thread overview]
Message-ID: <52D5E1CD.2020405@windriver.com> (raw)
In-Reply-To: <1389701498.23430.1.camel@jlt4.sipsolutions.net>
On 01/14/2014 08:11 PM, Johannes Berg wrote:
> On Tue, 2014-01-14 at 15:41 +0800, Ying Xue wrote:
>
>> @@ -2218,10 +2194,6 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info)
>> rdev->wiphy.coverage_class = old_coverage_class;
>> }
>> }
>> -
>> - bad_res:
>> - if (netdev)
>> - dev_put(netdev);
>> return result;
>
> I believe that could be "return 0;" now, which would make the code
> easier to read.
>
Yes, I will change it in next version.
Thanks,
Ying
> johannes
>
>
>
prev parent reply other threads:[~2014-01-15 1:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 7:40 [PATCH net-next 00/10] use appropriate APIs to get interfaces Ying Xue
2014-01-14 7:41 ` [PATCH net-next 01/10] Drivers: Staging: cxt1e1: use __dev_get_name instead of dev_get_name to find interfaces Ying Xue
2014-01-14 7:41 ` [PATCH net-next 02/10] bonding: use __dev_get_by_name instead of dev_get_by_name to find interface Ying Xue
2014-01-14 11:55 ` Veaceslav Falico
2014-01-14 7:41 ` [PATCH net-next 03/10] eql: " Ying Xue
2014-01-14 7:41 ` [PATCH net-next 04/10] dcb: " Ying Xue
2014-01-14 7:41 ` [PATCH net-next 05/10] decnet: use __dev_get_by_index instead of dev_get_by_index " Ying Xue
2014-01-14 7:41 ` [PATCH net-next 06/10] vxlan: " Ying Xue
2014-01-14 16:51 ` Stephen Hemminger
2014-01-14 7:41 ` [PATCH net-next 07/10] batman-adv: " Ying Xue
2014-01-14 12:43 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-01-14 12:43 ` Antonio Quartulli
2014-01-14 7:41 ` [PATCH net-next 08/10] caif: " Ying Xue
2014-01-14 7:41 ` [PATCH net-next 09/10] can: use " Ying Xue
2014-01-14 16:11 ` Oliver Hartkopp
2014-01-14 7:41 ` [PATCH net-next 10/10] net: nl80211: " Ying Xue
2014-01-14 12:11 ` Johannes Berg
2014-01-15 1:18 ` Ying Xue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D5E1CD.2020405@windriver.com \
--to=ying.xue@windriver.com \
--cc=antonio@meshcoding.com \
--cc=davem@davemloft.net \
--cc=dmitry.tarnyagin@lockless.no \
--cc=johannes@sipsolutions.net \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=stephen@networkplumber.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.