From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3FZo-0001XN-Mi for qemu-devel@nongnu.org; Tue, 14 Jan 2014 20:47:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3FZg-0003Iw-10 for qemu-devel@nongnu.org; Tue, 14 Jan 2014 20:47:28 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:52970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3FZf-0003Hk-8f for qemu-devel@nongnu.org; Tue, 14 Jan 2014 20:47:19 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 15 Jan 2014 11:47:15 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 9839A3578023 for ; Wed, 15 Jan 2014 12:47:13 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0F1S99030343202 for ; Wed, 15 Jan 2014 12:28:10 +1100 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0F1lBtW029985 for ; Wed, 15 Jan 2014 12:47:12 +1100 Message-ID: <52D5E89C.7080008@linux.vnet.ibm.com> Date: Wed, 15 Jan 2014 09:47:08 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1384307094-5836-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1384307094-5836-3-git-send-email-xiawenc@linux.vnet.ibm.com> <52AB0C17.8020704@redhat.com> <20131213134331.GI3916@dhcp-200-207.str.redhat.com> <87y53lkvkr.fsf@blackfin.pond.sub.org> <87sit0m1j2.fsf@blackfin.pond.sub.org> <87ob3gb3de.fsf@blackfin.pond.sub.org> In-Reply-To: <87ob3gb3de.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Kevin Wolf Cc: pbonzini@redhat.com, lcapitulino@redhat.com, mdroth@linux.vnet.ibm.com, Anthony Liguori , qemu-devel@nongnu.org ÓÚ 2014/1/13 18:08, Markus Armbruster дµÀ: > Ping^2! > > Markus Armbruster writes: > >> Ping? >> >> Markus Armbruster writes: >> >>> [Licensing problem, cc: Anthony] >>> >>> Kevin Wolf writes: >>> >>>> Am 13.12.2013 um 14:31 hat Eric Blake geschrieben: >>>>> On 11/12/2013 06:44 PM, Wenchao Xia wrote: >>>>>> +++ b/scripts/qapi-event.py >>>>>> @@ -0,0 +1,355 @@ >>>>>> +# >>>>>> +# QAPI event generator >>>>>> +# >>>>>> +# Copyright IBM, Corp. 2013 >>>>>> +# >>>>>> +# Authors: >>>>>> +# Wenchao Xia >>>>>> +# >>>>>> +# This work is licensed under the terms of the GNU GPLv2. >>>>> >>>>> Can you please use GPLv2+ (that is, add the "or later" clause)? We >>>>> already have GPLv2-only code, but I don't want to increase the size of >>>>> that unfortunate license choice. >>>> >>>> In fact, it's even worse: >>>> >>>> +# This work is licensed under the terms of the GNU GPLv2. >>>> +# See the COPYING.LIB file in the top-level directory. >>>> >>>> These two lines contradict each other, COPYING.LIB contains the >>>> LGPL 2.1. The same bad license header is in the other QAPI generator >>>> scripts, so it's only copy&paste here. >>> >>> Specifically: >>> >>> File Commit >>> scripts/qapi-commands.py c17d9908 >>> scripts/qapi-visit.py fb3182ce >>> scripts/qapi-types.py 06d64c62 >>> scripts/qapi.py 0f923be2 >>> >>> All four from Michael Roth via Luiz. >>> >>>> This doesn't make things easier, because if things are copied, the >>>> license of the source must be respected. And it seems rather dubious to >>>> me what this license actually is. If it's GPLv2-only, we can't just >>>> change it in the new copy. >>> >>> IANAL, and I wouldn't dare to judge which of the two conflicting license >>> claims takes precedence. Possibly neither, and then the files might >>> technically not be distributable. >>> >>> Anyway, this mess needs to be addressed. Michael, what was your >>> *intended* license? >>> >>> If it wasn't GPLv2+, then why? >>> >>> Do we need formal ACKs from all contributors to fix the licensing >>> comment in these four files? > I used GPLv2+ in my new files of v2, but not sure about other files. Michael, do you think other scripts should be changed either?