Re: [Qemu-devel] [PATCHv6 6/6] qemu-iotests: blacklist test 020 for NFS protocol

[Peter Lieven <pl@kamp.de>]

On 15.01.2014 07:27, Fam Zheng wrote:
> On Mon, 01/13 11:21, Peter Lieven wrote:
>> reopening is currently not supported.
>>
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>>   tests/qemu-iotests/020 |    5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020
>> index a42f32f..f8a849c 100755
>> --- a/tests/qemu-iotests/020
>> +++ b/tests/qemu-iotests/020
>> @@ -46,6 +46,11 @@ _supported_fmt qcow qcow2 vmdk qed
>>   _supported_proto file
>>   _supported_os Linux
>>   
>> +# NFS does not support bdrv_reopen_prepare thus qemu-img commit fails.
>> +if [ "$IMGPROTO" = "nfs" ]; then
>> +    _notrun "image protocol $IMGPROTO does not support bdrv_commit"
>> +fi
>> +
> Doesn't "_supported_proto file" above already skip this case?
>
> Fam
You are right, the proto should be generic and just NFS should be blacklisted.

Peter