From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: shmobile: lager: fix error return code check from clk_get()
Date: Wed, 15 Jan 2014 10:27:06 +0000 [thread overview]
Message-ID: <52D6627A.3060405@codethink.co.uk> (raw)
In-Reply-To: <1389725007-5023-2-git-send-email-ben.dooks@codethink.co.uk>
On 15/01/14 00:16, Simon Horman wrote:
> On Tue, Jan 14, 2014 at 06:43:26PM +0000, Ben Dooks wrote:
>> The lager_add_standard_devices() function calls clk_get() but then fails
>> to check that it returns an error pointer instead of NULL on failure.
>>
>> This was added by 4a606af2 ("ARM: shmobile: lager-reference: Instantiate
>> clkdevs for SCIF and CMT") patch in horms' renesas-boards2-for-v3.14~6
>> release.
>>
>> The issue is not serious as it does not cause a crash and seems to not be
>> actually causing any issues now the other clock bugs have been fixed.
>>
>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> Cc: Simon Horman <horms+renesas@verge.net.au>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>
> Thanks, I have queued up the following:
Great, will try and re-test on a latest devel branch in the next
few days.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
prev parent reply other threads:[~2014-01-15 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 18:43 [PATCH 1/2] ARM: shmobile: lager: fix error return code check from clk_get() Ben Dooks
2014-01-15 0:16 ` Simon Horman
2014-01-15 10:27 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D6627A.3060405@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.