From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Wed, 15 Jan 2014 11:04:59 +0000 Subject: Re: [PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub Message-Id: <52D66B5B.5060101@redhat.com> List-Id: References: <1389314596-18814-1-git-send-email-scottwood@freescale.com> In-Reply-To: <1389314596-18814-1-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Scott Wood Cc: Gleb Natapov , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, Stephen Hemminger , Alexander Graf Il 10/01/2014 01:43, Scott Wood ha scritto: > Commit 7940876e1330671708186ac3386aa521ffb5c182 ("kvm: make local > functions static") broke KVM PPC builds due to removing (rather than > moving) the stub version of kvm_vcpu_eligible_for_directed_yield(). > > This patch reintroduces it. > > Signed-off-by: Scott Wood > Cc: Stephen Hemminger > Cc: Alexander Graf > --- > virt/kvm/kvm_main.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 4733fa1..f896665 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -1771,6 +1771,11 @@ static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu) > > return eligible; > } > +#else > +static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu) > +{ > + return true; > +} > #endif I moved the #ifdef inside the function. Thanks for the fix. Paolo > > void kvm_vcpu_on_spin(struct kvm_vcpu *me) > Applied to kvm/queue From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub Date: Wed, 15 Jan 2014 12:04:59 +0100 Message-ID: <52D66B5B.5060101@redhat.com> References: <1389314596-18814-1-git-send-email-scottwood@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, Stephen Hemminger , Alexander Graf To: Scott Wood Return-path: In-Reply-To: <1389314596-18814-1-git-send-email-scottwood@freescale.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 10/01/2014 01:43, Scott Wood ha scritto: > Commit 7940876e1330671708186ac3386aa521ffb5c182 ("kvm: make local > functions static") broke KVM PPC builds due to removing (rather than > moving) the stub version of kvm_vcpu_eligible_for_directed_yield(). > > This patch reintroduces it. > > Signed-off-by: Scott Wood > Cc: Stephen Hemminger > Cc: Alexander Graf > --- > virt/kvm/kvm_main.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 4733fa1..f896665 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -1771,6 +1771,11 @@ static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu) > > return eligible; > } > +#else > +static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu) > +{ > + return true; > +} > #endif I moved the #ifdef inside the function. Thanks for the fix. Paolo > > void kvm_vcpu_on_spin(struct kvm_vcpu *me) > Applied to kvm/queue