From: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Martin Husemann <martin@NetBSD.org>
Subject: Re: [Qemu-devel] qemu 1.7.0 does not build on NetBSD (patch)
Date: Wed, 15 Jan 2014 13:33:22 +0100 [thread overview]
Message-ID: <52D68012.8090603@redhat.com> (raw)
In-Reply-To: <52B02428.20306@redhat.com>
Il 17/12/2013 11:15, Paolo Bonzini ha scritto:
> Il 17/12/2013 09:55, Martin Husemann ha scritto:
>> On NetBSD int8_t and friends are preprocessor macros expanding to __int8_t
>> (which is a typedef provided by machine dependent headers).
>>
>> include/exec/softmmu_template.h tries to safe 3 lines of code by using
>> preprosseor concatenation, which only will work if int8_t is not a define,
>> or defined to int8_t.
>>
>> The attached patch fixes this.
>
> Hi Martin, the patch looks good, but please resend it according to the
> rules in http://wiki.qemu.org/Contribute/SubmitAPatch - thanks!
Ping?
Paolo
next prev parent reply other threads:[~2014-01-15 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 8:55 [Qemu-devel] qemu 1.7.0 does not build on NetBSD (patch) Martin Husemann
2013-12-17 10:15 ` Paolo Bonzini
2014-01-15 12:33 ` Paolo Bonzini [this message]
2014-01-18 13:47 ` [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD Martin Husemann
2014-01-18 13:59 ` Peter Maydell
2014-01-21 15:38 ` Richard Henderson
2014-01-21 15:42 ` [Qemu-trivial] " Andreas Färber
2014-01-21 15:42 ` Andreas Färber
2014-01-21 18:11 ` [Qemu-trivial] " Michael Tokarev
2014-01-21 18:11 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D68012.8090603@redhat.com \
--to=pbonzini@redhat.com \
--cc=martin@NetBSD.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.