From mboxrd@z Thu Jan  1 00:00:00 1970
From: annie li <annie.li@oracle.com>
Subject: Re: [PATCH] tools/xl: correctly shows split
 eventchannel for netfront
Date: Wed, 15 Jan 2014 23:18:20 +0800
Message-ID: <52D6A6BC.4060603@oracle.com>
References: <1389724428-3228-1-git-send-email-Annie.li@oracle.com>
	<1389791597.12434.216.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1389791597.12434.216.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: ian.jackson@eu.citrx.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org


On 2014-1-15 21:13, Ian Campbell wrote:
> On Wed, 2014-01-15 at 02:33 +0800, Annie Li wrote:
>> From: Annie Li <annie.li@oracle.com>
>>
>> After split eventchannel feature was supported by netback/netfront,
>> "xl network-list" does not show eventchannel correctly. Add tx-/rx-evt-ch
>> to show tx/rx eventchannel correctly.
>>
>> Signed-off-by: Annie Li <annie.li@oracle.com>
> How critical is this for 4.4?

I think it can wait. This issue only happens with split event channel 
feature implemented in latest netback/netfront, "xl network-list" works 
OK for old netback/netfront.

>
> Please consider
> http://wiki.xen.org/wiki/Xen_Roadmap/4.4#Exception_guidelines_for_after_the_code_freeze and make a case for it if you think it should go in.
>
>> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
>> index 649ce50..e6368c7 100644
>> --- a/tools/libxl/libxl_types.idl
>> +++ b/tools/libxl/libxl_types.idl
>> @@ -488,7 +488,8 @@ libxl_nicinfo = Struct("nicinfo", [
>>       ("frontend_id", uint32),
>>       ("devid", libxl_devid),
>>       ("state", integer),
>> -    ("evtch", integer),
>> +    ("evtch_tx", integer),
>> +    ("evtch_rx", integer),
> This needs backwards compatibility handling, see the big comment at the
> head of libxl.h and the other examples in that file. I'm doubtful that
> you will be able to remove the evtch field without breaking the API, so
> it probably needs to stay even if it is explicitly invalid under some
> circumstances.
>
> It also needs a suitable LIBXL_HAVE_ #define, again see libxl.h.

Yes, this patch does not handle backwards compatibility,  and probably 
breaks the API. Let me fix them, thanks!

Thanks
Annie
>
> Ian.
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel