From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hector Palacios <hector.palacios@digi.com>
Date: Wed, 15 Jan 2014 17:37:55 +0100
Subject: [U-Boot] [PATCH 1/2] env_mmc: make board configurable the
 partition for the environment
In-Reply-To: <CAP9ODKr-KwKpRP3gYK1t5qWaWBJPuA6DrPrkLNEof3fRUfJtAw@mail.gmail.com>
References: <1389783236-8464-1-git-send-email-hector.palacios@digi.com>
	<CAP9ODKr-KwKpRP3gYK1t5qWaWBJPuA6DrPrkLNEof3fRUfJtAw@mail.gmail.com>
Message-ID: <52D6B963.1050301@digi.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Otavio,

On 01/15/2014 12:09 PM, Otavio Salvador wrote:
> Hello Hector,
>
> On Wed, Jan 15, 2014 at 8:53 AM, Hector Palacios <hector.palacios@digi.com
> <mailto:hector.palacios@digi.com>> wrote:
>
>     This complements commit 9404a5fc7cb58 "env_mmc: allow environment to be
>     in an eMMC partition" by allowing boards to accommodate the partition
>     to use for the environment in different scenarios (similarly to what is
>     done with the mmc dev number). Depending on the detected boot media,
>     boards may decide to store the environment in a different partition.
>
>     The __weak function also allows to remove some ifdefs from the code.
>     If CONFIG_SYS_MMC_ENV_PART is not defined, partition 0 is assumed
>     (default value for U-Boot when a partition is not provided).
>
>     Signed-off-by: Hector Palacios <hector.palacios@digi.com
>     <mailto:hector.palacios@digi.com>>
>     CC: Stephen Warren <swarren at nvidia.com <mailto:swarren@nvidia.com>>
>     CC: Andy Fleming <afleming at freescale.com <mailto:afleming@freescale.com>>
>     ---
>       common/env_mmc.c | 27 +++++++++++++++------------
>       1 file changed, 15 insertions(+), 12 deletions(-)
>
>     diff --git a/common/env_mmc.c b/common/env_mmc.c
>     index 78c2bc7a1f08..d569b070e005 100644
>     --- a/common/env_mmc.c
>     +++ b/common/env_mmc.c
>     @@ -64,6 +64,13 @@ __weak int mmc_get_env_addr(struct mmc *mmc, int copy, u32
>     *env_addr)
>       __weak int mmc_get_env_devno(void)
>       {
>              return CONFIG_SYS_MMC_ENV_DEV;
>     +
>     +__weak int mmc_get_env_partno(void)
>     +{
>     +#ifdef CONFIG_SYS_MMC_ENV_PART
>     +       return CONFIG_SYS_MMC_ENV_PART;
>     +#endif
>     +       return 0;
>
>
> Maybe:
>
> #ifndef CONFIG_SYS_MMC_ENV_PART
> #define CONFIG_SYS_MMC_ENV_PART 0
> #endif
>
> __weak int mmc_get_env_partno(void)
> {
>      return CONFIG_SYS_MMC_ENV_PART;
> }

Much better. I'll do this for both patches. Thanks.

Best regards,
--
Hector Palacios