Re: [Qemu-devel] [PATCH V5] char: restore read callback on a reattached (hotplug) chardev

[Gal Hammer <ghammer@redhat.com>]

Hi,

Anyone?

Thanks,

     Gal.

On 07/01/2014 09:25, Amit Shah wrote:
> On (Wed) 18 Dec 2013 [16:15:19], Gal Hammer wrote:
>> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
>> set the chr handlers to NULL. However when the device is plugged back,
>> its read callback is not restored so data can't be transferred from the
>> host to the guest (e.g. via the virtio-serial port).
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1027181
>>
>> Signed-off-by: Gal Hammer <ghammer@redhat.com>
>>
>> ---
>>   qemu-char.c | 21 +++++++++++++++++----
>>   1 file changed, 17 insertions(+), 4 deletions(-)
>>
>> V5: - remove_fd_in_watch in fd_chr_update_read_handler as well.
>>      - fix pty backend.
>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
> Gerd, could you take a look as well?
>
> 		Amit
>