From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH RFC 4/4] xen-netfront: Add support
 for	multiple queues
Date: Thu, 16 Jan 2014 11:04:25 +0000
Message-ID: <52D7BCB9.2020807@citrix.com>
References: <1389803004-31812-1-git-send-email-andrew.bennieston@citrix.com>	<1389803004-31812-5-git-send-email-andrew.bennieston@citrix.com>	<20140116002706.GJ5331@zion.uk.xensource.com>
	<52D7B379.201@citrix.com> <52D7B6F1.1040604@citrix.com>
	<52D7B76E.2080001@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1W3kkd-000559-EG
	for xen-devel@lists.xenproject.org; Thu, 16 Jan 2014 11:04:43 +0000
In-Reply-To: <52D7B76E.2080001@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Bennieston <andrew.bennieston@citrix.com>
Cc: xen-devel@lists.xenproject.org, paul.durrant@citrix.com, Wei Liu <wei.liu2@citrix.com>, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 16/01/14 10:41, Andrew Bennieston wrote:
> On 16/01/14 10:39, David Vrabel wrote:
>> On 16/01/14 10:24, Andrew Bennieston wrote:
>>> On 16/01/14 00:27, Wei Liu wrote:
>>>> On Wed, Jan 15, 2014 at 04:23:24PM +0000, Andrew J. Bennieston wrote:
>>>>
>>>>> +            goto error;
>>>>> +        }
>>>>> +        snprintf(path, pathsize, "%s/queue-%u",
>>>>> +                dev->nodename, queue->number);
>>>>> +    }
>>>>> +    else
>>>>> +        path = (char *)dev->nodename;
>>>>
>>>> Coding style. Should be surounded by {};
>>>
>>> OK.
>>
>> Linux style is single line blocks are not surrounded by braces.  You
>> should have the else on the same line as the preceeding } though.
>>
>> i.e.,
>>
>> if (...) {
>>     one_line()
>>     two_line()
>>     red_line()
>>     blue_line()
>> } else
>>     a_line()
>>
>> David
>>
> Right; I'll make sure this consistently done throughout.

Nope. Turns out I'm wrong.

In my defense, the last time I read CodingStyle (which was a
considerable time ago!) it didn't say this.

David