From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [RFC v2 0/3] DRM Anonymous Inodes Date: Thu, 16 Jan 2014 12:51:25 +0100 Message-ID: <52D7C7BD.2080601@vmware.com> References: <1388760087-17746-1-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com [208.91.2.13]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F54B105F6A for ; Thu, 16 Jan 2014 03:51:29 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: David Herrmann Cc: Daniel Vetter , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org David, I haven't had time to test on vmwgfx yet, but looking through the code it looks good to me. Acked-by: Thomas Hellstrom /Thomas On 01/16/2014 12:29 PM, David Herrmann wrote: > Hi > > On Fri, Jan 3, 2014 at 3:41 PM, David Herrmann wrote: >> Hi >> >> With 3.13-rc1 the required VFS core changes for anonymous backing inodes in DRM >> got merged. This series reworks the previous patches (I think from early >> August '13) and finally replaces the ugly drm_device->dev_mapping hack. >> >> The patches should be fairly obvious. As I currently only have nouveau here, I'd >> be happy to get some more testers with other drivers. >> >> Patch #1 adds an internal private mount point to DRM core. >> Patch #2 replaces ->dev_mapping with a private anonymous inode for each device. >> Patch #3 removes the delayed dev_mapping initialization in TTM. >> >> The internal mnt-point is based on fs/aio.c and fs/anon_inode.c which do the >> same. It's not clear to me why we cannot share the mnt-point between all these, >> but Al Viro made clear that he will reject any patches on anon_inode.c which do >> that. So lets follow his recommendation and use our own internal mnt-point. > Also tested on i915 ivb now (before: nouveau+TTM). I think this is > ready for 3.14 if nobody finds any issues. > > Thanks > David > >> Thanks >> David >> >> David Herrmann (3): >> drm: add pseudo filesystem for shared inodes >> drm: use anon-inode instead of relying on cdevs >> drm: init TTM dev_mapping in ttm_bo_device_init() >> >> drivers/gpu/drm/ast/ast_ttm.c | 5 +++-- >> drivers/gpu/drm/cirrus/cirrus_ttm.c | 5 +++-- >> drivers/gpu/drm/drm_drv.c | 37 ++++++++++++++++++++++++++++++++++ >> drivers/gpu/drm/drm_fops.c | 25 +++-------------------- >> drivers/gpu/drm/drm_stub.c | 12 ++++++++++- >> drivers/gpu/drm/i915/i915_gem.c | 3 ++- >> drivers/gpu/drm/mgag200/mgag200_ttm.c | 5 +++-- >> drivers/gpu/drm/nouveau/nouveau_gem.c | 2 -- >> drivers/gpu/drm/nouveau/nouveau_ttm.c | 4 +++- >> drivers/gpu/drm/omapdrm/omap_gem.c | 34 +++++++++++++++---------------- >> drivers/gpu/drm/qxl/qxl_object.c | 2 -- >> drivers/gpu/drm/qxl/qxl_ttm.c | 6 +++--- >> drivers/gpu/drm/radeon/radeon_object.c | 1 - >> drivers/gpu/drm/radeon/radeon_ttm.c | 5 +++-- >> drivers/gpu/drm/ttm/ttm_bo.c | 3 ++- >> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 5 +++-- >> include/drm/drmP.h | 3 ++- >> include/drm/drm_vma_manager.h | 6 +++--- >> include/drm/ttm/ttm_bo_driver.h | 2 ++ >> 19 files changed, 100 insertions(+), 65 deletions(-) >> >> -- >> 1.8.5.2 >> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel