From: Pontus Fuchs <pontus.fuchs@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Don't touch split_start when split dump is not used
Date: Thu, 16 Jan 2014 14:18:03 +0100 [thread overview]
Message-ID: <52D7DC0B.9060206@gmail.com> (raw)
In-Reply-To: <1389878160.4345.3.camel@jlt4.sipsolutions.net>
On 2014-01-16 14:16, Johannes Berg wrote:
> On Thu, 2014-01-16 at 14:06 +0100, Pontus Fuchs wrote:
>> When the netlink skb is exhausted split_start is left set. In the
>> subsequent retry, with a larger buffer, the dump is continued from the
>> failing point instead of from the beginning.
>
>> +static void split_start_inc(struct nl80211_dump_wiphy_state *state)
>> +{
>> + if (state->split)
>> + state->split_start++;
>> +}
>
> Wouldn't it be easier to just reset it in this case?
Sure. If you prefer that I can do that instead.
//Pontus
next prev parent reply other threads:[~2014-01-16 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 13:06 [PATCH] nl80211: Don't touch split_start when split dump is not used Pontus Fuchs
2014-01-16 13:16 ` Johannes Berg
2014-01-16 13:18 ` Pontus Fuchs [this message]
2014-01-16 13:20 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D7DC0B.9060206@gmail.com \
--to=pontus.fuchs@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.