From: Eric Blake <eblake@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: sw@weilnetz.de, mjt@tls.msk.ru, lcapitulino@redhat.com,
blauwirbel@gmail.com, aliguori@amazon.com, stefanha@gmail.com,
pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate 'id'
Date: Thu, 16 Jan 2014 09:50:44 -0700 [thread overview]
Message-ID: <52D80DE4.6030100@redhat.com> (raw)
In-Reply-To: <1389890079-21853-3-git-send-email-imammedo@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On 01/16/2014 09:34 AM, Igor Mammedov wrote:
s/ingnore/ignore/ in subject
> object_property_add_child() may fail if 'id' matches
> an already existing object. Which meansi an incorrect
s/meansi/means/
> command line.
> So instead of silently ignoring error, report it and
> terminate QEMU.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> vl.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
Fix those, and you can add:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-01-16 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 16:34 [Qemu-devel] [PATCH v1 0/4] -object/object-add add 2nd stage initialization Igor Mammedov
2014-01-16 16:34 ` [Qemu-devel] [PATCH v1 1/4] object_add: consolidate error handling Igor Mammedov
2014-01-16 16:34 ` [Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate 'id' Igor Mammedov
2014-01-16 16:50 ` Eric Blake [this message]
2014-01-16 16:34 ` [Qemu-devel] [PATCH v1 3/4] add optional 2nd stage initialization to -object/object-add commands Igor Mammedov
2014-01-16 16:34 ` [Qemu-devel] [PATCH v1 4/4] virtio_rng: replace custom backend API with UserCreatable.complete() callback Igor Mammedov
2014-08-09 4:32 ` Amos Kong
2014-01-17 7:10 ` [Qemu-devel] [PATCH v1 0/4] -object/object-add add 2nd stage initialization Stefan Hajnoczi
2014-01-22 18:33 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D80DE4.6030100@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@amazon.com \
--cc=blauwirbel@gmail.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@gmail.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.