Re: [PATCH] gprs: Use "internet" apn for auto-created context

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

Hi Slava,

On 01/16/2014 08:43 AM, Slava Monich wrote:
> Such an access point has a pretty good chance to actually work.
> ---
>   src/gprs.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/src/gprs.c b/src/gprs.c
> index e379f7b..01ff875 100644
> --- a/src/gprs.c
> +++ b/src/gprs.c
> @@ -2992,8 +2992,13 @@ static void ofono_gprs_finish_register(struct ofono_gprs *gprs)
>   	struct ofono_modem *modem = __ofono_atom_get_modem(gprs->atom);
>   	const char *path = __ofono_atom_get_path(gprs->atom);
>
> -	if (gprs->contexts == NULL) /* Automatic provisioning failed */
> -		add_context(gprs, NULL, OFONO_GPRS_CONTEXT_TYPE_INTERNET);
> +	if (gprs->contexts == NULL) { /* Automatic provisioning failed */
> +		struct pri_context *context = add_context(gprs, NULL,
> +					OFONO_GPRS_CONTEXT_TYPE_INTERNET);
> +		if (context) {
> +			strcpy(context->context.apn, "internet");
> +		}
> +	}

Nope.  This doesn't belong in the core.  If you want to guess wildly, 
please do so in a provisioning plugin.  That is what they're there for. 
  You can have multiple provisioning plugins by the way.

>
>   	if (!g_dbus_register_interface(conn, path,
>   					OFONO_CONNECTION_MANAGER_INTERFACE,
>

Regards,
-Denis