From: Daniel Borkmann <dborkman@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Michal Sekletar <msekleta@redhat.com>,
netdev@vger.kernel.org, Michael Kerrisk <mtk.manpages@gmail.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: introduce SO_BPF_EXTENSIONS
Date: Thu, 16 Jan 2014 19:52:42 +0100 [thread overview]
Message-ID: <52D82A7A.3090106@redhat.com> (raw)
In-Reply-To: <1389898146.31367.413.camel@edumazet-glaptop2.roam.corp.google.com>
On 01/16/2014 07:49 PM, Eric Dumazet wrote:
> On Thu, 2014-01-16 at 19:34 +0100, Daniel Borkmann wrote:
>
>>> Thank you for the review. Btw, what do you think about define for parisc? I am
>>
>> Yes, saw that in the patch and had similar thoughts.
>>
>>> not sure I grok 0x4048 for SO_MAX_PACING_RATE and hence not sure about 0x4029
>>> for SO_BPF_EXTENSIONS.
>>
>> Hmm, maybe typo; SO_MAX_PACING_RATE should have been a 0x4028 ?
>
> Indeed it was a typo.
>
> I think its time to change this, as this was added for linux-3.13
Ok, are you sending out a patch?
Thanks,
Daniel
next prev parent reply other threads:[~2014-01-16 18:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 16:14 [PATCH] net: introduce SO_BPF_EXTENSIONS Michal Sekletar
2014-01-16 16:41 ` Daniel Borkmann
2014-01-16 17:13 ` Michal Sekletar
2014-01-16 17:26 ` Michal Sekletar
2014-01-16 18:34 ` Daniel Borkmann
2014-01-16 18:49 ` Eric Dumazet
2014-01-16 18:52 ` Daniel Borkmann [this message]
2014-01-16 19:09 ` Eric Dumazet
2014-01-16 19:15 ` [PATCH] parisc: fix SO_MAX_PACING_RATE typo Eric Dumazet
2014-01-18 2:11 ` David Miller
2014-01-16 19:24 ` [PATCH] net: introduce SO_BPF_EXTENSIONS Daniel Borkmann
-- strict thread matches above, loose matches on Subject: below --
2013-11-28 11:57 Michal Sekletar
2013-11-28 17:31 ` Eric Dumazet
2013-11-29 14:13 ` Daniel Borkmann
2013-12-05 17:28 ` Michal Sekletár
2013-12-05 17:32 ` Eric Dumazet
2013-12-06 9:50 ` David Laight
2013-12-06 10:02 ` Daniel Borkmann
2013-12-06 11:15 ` David Laight
2013-12-06 12:04 ` Daniel Borkmann
2013-12-06 17:15 ` David Miller
2013-12-09 14:09 ` Michal Sekletár
2013-12-10 0:25 ` David Miller
2013-12-06 17:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D82A7A.3090106@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=msekleta@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.