From: Mike Christie <michaelc@cs.wisc.edu>
To: Jayamohan Kallickal <jayamohank@gmail.com>
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
Jayamohan Kallickal <jayamohan.kallickal@emulex.com>,
John Soni Jose <sony.john-n@emulex.com>
Subject: Re: [PATCH 4/7] be2iscsi : Fix statistics update in the driver.
Date: Fri, 17 Jan 2014 02:47:19 -0600 [thread overview]
Message-ID: <52D8EE17.7070904@cs.wisc.edu> (raw)
In-Reply-To: <1389573741-3523-4-git-send-email-jayamohan.kallickal@emulex.com>
On 01/12/2014 06:42 PM, Jayamohan Kallickal wrote:
>
> diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
> index 0076119..d21ad9e 100644
> --- a/drivers/scsi/be2iscsi/be_main.h
> +++ b/drivers/scsi/be2iscsi/be_main.h
> @@ -449,6 +449,25 @@ struct beiscsi_conn {
> struct sgl_handle *plogin_sgl_handle;
> struct beiscsi_session *beiscsi_sess;
> struct iscsi_task *task;
> +
> + /* CXN statistics */
> + /* Xmit Counters */
> + uint32_t noptx_pdus;
> + uint32_t login_pdus;
> + uint32_t text_pdus;
> + uint32_t logout_pdus;
> + uint32_t snack_pdus;
> +
> + /* Rx Counters */
> + uint32_t noprx_pdus;
> + uint32_t textrsp_pdus;
> + uint32_t logoutrsp_pdus;
> + uint32_t async_pdus;
> + uint32_t rjt_pdus;
> +
> + /* Error Counters */
> + uint32_t digest_err;
> + uint32_t format_err;
> };
>
You should put these on the iscsi_conn struct then have
__iscsi_complete_pdu handle the counters.
libiscsi should then also setup processing of those stats. You should
make a libiscsi helper which the drivers call. See iscsi_tcp
iscsi_sw_tcp_conn_get_stats call to iscsi_tcp_conn_get_stats for an
example for how it is done with libiscsi_tcp and lower level stats it
manages.
next prev parent reply other threads:[~2014-01-17 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 0:42 [PATCH 1/7] be2iscsi: Fix handling timed out MBX completion from FW Jayamohan Kallickal
2014-01-13 0:42 ` [PATCH 2/7] be2iscsi: Fix port speed typo in driver Jayamohan Kallickal
2014-01-13 0:42 ` [PATCH 3/7] be2iscsi : Fix IRQ_Affinity support " Jayamohan Kallickal
2014-01-13 0:42 ` [PATCH 4/7] be2iscsi : Fix statistics update in the driver Jayamohan Kallickal
2014-01-17 8:47 ` Mike Christie [this message]
2014-01-13 0:42 ` [PATCH 5/7] be2iscsi: Fix doorbell format for EQ/CQ/RQ s per SLI spec Jayamohan Kallickal
2014-01-17 8:53 ` Mike Christie
2014-01-13 0:42 ` [PATCH 6/7] be2iscsi: Fix the session cleanup when reboot/shutdown happens Jayamohan Kallickal
2014-01-13 0:42 ` [PATCH 7/7] be2iscsi : Bump driver version Jayamohan Kallickal
2014-01-13 0:42 ` [PATCH 0/7] be2iscsi: Update to 10.2.84.0 Jayamohan Kallickal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D8EE17.7070904@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jayamohan.kallickal@emulex.com \
--cc=jayamohank@gmail.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sony.john-n@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.