From: Rik van Riel <riel@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@vger.kernel.org,
mingo@redhat.com, chegu_vinod@hp.com, mgorman@suse.de,
Rik van Riel <riel@surriel.com>
Subject: Re: [PATCH 6/6] numa,sched: normalize faults_from stats and weigh by CPU use
Date: Fri, 17 Jan 2014 09:51:44 -0500 [thread overview]
Message-ID: <52D94380.5040901@redhat.com> (raw)
In-Reply-To: <20140117095459.GF11314@laptop.programming.kicks-ass.net>
On 01/17/2014 04:54 AM, Peter Zijlstra wrote:
> On Fri, Jan 17, 2014 at 01:17:36AM -0500, riel@redhat.com wrote:
>> + /*
>> + * Normalize the faults_from, so all tasks in a group
>> + * count according to CPU use, instead of by the raw
>> + * number of faults. This prevents the situation where
>> + * the garbage collector totally dominates the stats,
>> + * and the access patterns of the worker threads are
>> + * ignored.
>> + */
>
> Instead of focusing on the one example (GC) here, I would suggest
> saying something along the lines of: Tasks with little runtime have
> little over-all impact on throughput and thus their faults are less
> important.
Thanks for the review, I have updated the comment
accordingly.
Does anybody else have comments on this series, or should
I start begging for Acked-by: and Reviewed-by: lines? :)
--
All rights reversed
next prev parent reply other threads:[~2014-01-17 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 6:17 [PATCH 0/6] pseudo-interleaving for automatic NUMA balancing riel
2014-01-17 6:17 ` [PATCH 1/6] numa,sched,mm: remove p->numa_migrate_deferred riel
2014-01-17 6:17 ` [PATCH 2/6] numa,sched: track from which nodes NUMA faults are triggered riel
2014-01-17 6:17 ` [PATCH 3/6] numa,sched: build per numa_group active node mask from faults_from statistics riel
2014-01-17 6:17 ` [PATCH 4/6] numa,sched: tracepoints for NUMA balancing active nodemask changes riel
2014-01-17 6:17 ` [PATCH 5/6] numa,sched,mm: use active_nodes nodemask to limit numa migrations riel
2014-01-17 6:17 ` [PATCH 6/6] numa,sched: normalize faults_from stats and weigh by CPU use riel
2014-01-17 9:54 ` Peter Zijlstra
2014-01-17 14:51 ` Rik van Riel [this message]
2014-01-17 15:04 ` Peter Zijlstra
2014-01-17 18:47 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D94380.5040901@redhat.com \
--to=riel@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.