From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4Avl-0000wo-Bx for qemu-devel@nongnu.org; Fri, 17 Jan 2014 10:02:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W4Avd-0005TE-26 for qemu-devel@nongnu.org; Fri, 17 Jan 2014 10:01:57 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49743 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4Avc-0005Sv-Sh for qemu-devel@nongnu.org; Fri, 17 Jan 2014 10:01:49 -0500 Message-ID: <52D945D7.4050901@suse.de> Date: Fri, 17 Jan 2014 16:01:43 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1389781375-11774-1-git-send-email-kwolf@redhat.com> <1389781375-11774-37-git-send-email-kwolf@redhat.com> <52D6A6E5.8080407@redhat.com> <20140116100326.GC3369@dhcp-200-207.str.redhat.com> In-Reply-To: <20140116100326.GC3369@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 36/42] qapi: QMP interface for blkdebug and blkverify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws Am 16.01.2014 11:03, schrieb Kevin Wolf: > Am 15.01.2014 um 16:19 hat Eric Blake geschrieben: >> On 01/15/2014 03:22 AM, Kevin Wolf wrote: >>> From: Max Reitz >>> >>> Add structures to support blkdebug and blkverify in blockdev-add. >>> >>> Signed-off-by: Max Reitz >>> Signed-off-by: Kevin Wolf >>> --- >>> qapi-schema.json | 113 +++++++++++++++++++++++++++++++++++++++++++++= ++++++++-- >>> 1 file changed, 109 insertions(+), 4 deletions(-) >> >> Sorry for not noticing this sooner, but we still have some interface >> problems that need to be ironed out. >=20 > Nothing that should hold up this pull request, there are just a few > improvements that can be done in a follow-up. >=20 >>> diff --git a/qapi-schema.json b/qapi-schema.json >>> index f27c48a..35f7b34 100644 >>> --- a/qapi-schema.json >>> +++ b/qapi-schema.json >>> @@ -4201,6 +4201,113 @@ >>> '*pass-discard-other': 'bool' } } >>> =20 >>> ## >>> +# @BlkdebugEvent >>> +# >>> +# Trigger events supported by blkdebug. >>> +## >>> +{ 'enum': 'BlkdebugEvent', >> >> Missing a 'Since: 2.0' designation; would be worth adding that in a >> followup patch. >=20 > Ack. >=20 >>> + 'data': [ 'l1_update', 'l1_grow.alloc_table', 'l1_grow.write_table= ', >>> + 'l1_grow.activate_table', 'l2_load', 'l2_update', >>> + 'l2_update_compressed', 'l2_alloc.cow_read', 'l2_alloc.w= rite', >>> + 'read_aio', 'read_backing_aio', 'read_compressed', 'writ= e_aio', >>> + 'write_compressed', 'vmstate_load', 'vmstate_save', 'cow= _read', >>> + 'cow_write', 'reftable_load', 'reftable_grow', 'reftable= _update', >>> + 'refblock_load', 'refblock_update', 'refblock_update_par= t', >>> + 'refblock_alloc', 'refblock_alloc.hookup', 'refblock_all= oc.write', >>> + 'refblock_alloc.write_blocks', 'refblock_alloc.write_tab= le', >>> + 'refblock_alloc.switch_table', 'cluster_alloc', >>> + 'cluster_alloc_bytes', 'cluster_free', 'flush_to_os', >>> + 'flush_to_disk' ] } >> >> Do we want to prefer '-' over '_' in all these names? >=20 > These are existing names from the blkdebug configuration file. If we > wanted to have '-' in QMP and '_' in the config file, we'd have to have > some conversion somewhere. Uglier than having underscores here, imho. [snip] FWIW for -cpu we added code to do an automatic conversion from '_' to '-' so that we could name QOM properties the new way while keeping command line compatibility. As a side-effect, both became possible IIUC. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg