From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Meier Subject: Re: [PATCH] ASoC: wm8804: Allow control of master clock divider in PLL generation Date: Fri, 17 Jan 2014 19:44:02 +0100 Message-ID: <52D979F2.8070202@koalo.de> References: <52D95DA2.7000509@koalo.de> <20140117175927.GZ17314@sirena.org.uk> <52D97120.8030606@koalo.de> <20140117183332.GC17314@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140117183332.GC17314@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Daniel Matuschek , "alsa-devel@alsa-project.org" , Dimitris.Papastamos@wolfsonmicro.com, Liam Girdwood , perex@perex.cz, Takashi Iwai , patches@opensource.wolfsonmicro.com, "linux-kernel@vger.kernel.org" List-Id: alsa-devel@alsa-project.org On 01/17/2014 07:33 PM, Mark Brown wrote: > On Fri, Jan 17, 2014 at 07:06:24PM +0100, Florian Meier wrote: >> > Intentionally off-list? Oh no - I am sorry! >> If I remember correctly the error was >> "codec can not start from non-off bias with idle_bias_off==true" > >> I think the solution is just to set idle_bias_off = false and everything >> seems to be working with that. I just don't know if there might be any >> side effects. > > Setting it to false increases power consumption since the device is > kept more powered on when idle but reduces startup time from idle. For > digital only devices like the wm8804 there shouldn't be any reason to > keep it powered up when not in use, the startup time is generally > negligable anyway. > So a better solution would be to set SND_SOC_BIAS_OFF instead of SND_SOC_BIAS_STANDBY at the end of probe?