All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuri <yuri@rawbw.com>
To: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: git quietly fails on https:// URL, https errors are never reported to user
Date: Fri, 17 Jan 2014 12:39:39 -0800	[thread overview]
Message-ID: <52D9950B.3030300@rawbw.com> (raw)
In-Reply-To: <20140117201325.GB775@sigill.intra.peff.net>

On 01/17/2014 12:13, Jeff King wrote:
>    $ git clonehttps://google.com/foo.git
>    Cloning into 'foo'...
>    fatal: repository 'https://google.com/foo.git/' not found
>    fatal: Reading from helper 'git-remote-https' failed
>
> That second line is not adding anything, and IMHO is making things
> uglier and more confusing. We_expected_  the helper to hang up; that's
> how it signals an error to us. It is not an unexpected condition at all.
> The exit(128) we do is simply propagating the error report of the
> helper.
>
> That's the common error case: the message is redundant and annoying. The
> _uncommon_  case is the one Yuri hit: some library misconfiguration that
> causes the helper not to run at all.  Adding back any message is hurting
> the common case to help the uncommon one.

But you can use the error code value to convey the cause of the failure 
to git, and avoid an unnecessary message in git itself. Based on the 
error code value git could tell if the error has already been reported 
to user.

Yuri

  parent reply	other threads:[~2014-01-17 20:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 12:27 git quietly fails on https:// URL, https errors are never reported to user Yuri
2014-01-16 18:03 ` Jeff King
2014-01-16 19:28   ` Yuri
2014-01-17  9:40   ` Yuri
2014-01-17 19:43     ` Junio C Hamano
2014-01-17 20:13       ` Jeff King
2014-01-17 20:18         ` Jeff King
2014-01-17 20:39         ` Yuri [this message]
2014-01-17 21:10           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D9950B.3030300@rawbw.com \
    --to=yuri@rawbw.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.