From: Eric Sandeen <sandeen@sandeen.net>
To: Brian Foster <bfoster@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: use tr_growrtalloc for growing rt files
Date: Fri, 17 Jan 2014 14:52:41 -0600 [thread overview]
Message-ID: <52D99819.2090405@sandeen.net> (raw)
In-Reply-To: <1389989370-12159-1-git-send-email-bfoster@redhat.com>
On 1/17/14, 2:09 PM, Brian Foster wrote:
> This is a regression from the following commit:
>
> 3d3c8b5222b9 xfs: refactor xfs_trans_reserve() interface
>
> Use the tr_growrtalloc log reservation for growing the
> bitmap/summary files.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Looks right to me. :)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/xfs/xfs_rtalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index a6a76b2..ec5ca65 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -842,7 +842,7 @@ xfs_growfs_rt_alloc(
> /*
> * Reserve space & log for one extent added to the file.
> */
> - error = xfs_trans_reserve(tp, &M_RES(mp)->tr_growdata,
> + error = xfs_trans_reserve(tp, &M_RES(mp)->tr_growrtalloc,
> resblks, 0);
> if (error)
> goto error_cancel;
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-01-17 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 20:09 [PATCH] xfs: use tr_growrtalloc for growing rt files Brian Foster
2014-01-17 20:52 ` Eric Sandeen [this message]
2014-01-18 4:16 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D99819.2090405@sandeen.net \
--to=sandeen@sandeen.net \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.