From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Fri, 17 Jan 2014 23:02:06 +0100 Subject: [ath9k-devel] [PATCH 0/11] use ether_addr_equal_64bits In-Reply-To: <20140117212410.GA13930@amd.pavel.ucw.cz> References: <1388427307-8691-1-git-send-email-Julia.Lawall@lip6.fr> <20140117212410.GA13930@amd.pavel.ucw.cz> Message-ID: <52D9A85E.8070306@rempel-privat.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Am 17.01.2014 22:24, schrieb Pavel Machek: > On Mon 2013-12-30 19:14:56, Julia Lawall wrote: >> Ether_addr_equal_64bits is more efficient than ether_addr_equal, and can be >> used when each argument is an array within a structure that contains at >> least two bytes of data beyond the array. > > I mean, yes, it is probably faster, and yes, most structures probably > contain two more bytes, but... is the uglyness worth the speedup? I'd > say this should not be done except in very time-critical places... > Pavel This code run on every received beacon, almost on every wifi driver (If i understand what you mean.) -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 295 bytes Desc: OpenPGP digital signature Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20140117/a291f46a/attachment.pgp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Fri, 17 Jan 2014 22:02:06 +0000 Subject: Re: [PATCH 0/11] use ether_addr_equal_64bits Message-Id: <52D9A85E.8070306@rempel-privat.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="wPeiUu57NahR2I82nneDslo4JQxIfmkgx" List-Id: References: <1388427307-8691-1-git-send-email-Julia.Lawall@lip6.fr> <20140117212410.GA13930@amd.pavel.ucw.cz> In-Reply-To: <20140117212410.GA13930@amd.pavel.ucw.cz> To: Pavel Machek , Julia Lawall Cc: ath9k-devel@lists.ath9k.org, kernel-janitors@vger.kernel.org, ath5k-devel@lists.ath5k.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, "John W. Linville" , users@rt2x00.serialmonkey.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wPeiUu57NahR2I82nneDslo4JQxIfmkgx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 17.01.2014 22:24, schrieb Pavel Machek: > On Mon 2013-12-30 19:14:56, Julia Lawall wrote: >> Ether_addr_equal_64bits is more efficient than ether_addr_equal, and c= an be >> used when each argument is an array within a structure that contains a= t >> least two bytes of data beyond the array. >=20 > I mean, yes, it is probably faster, and yes, most structures probably > contain two more bytes, but... is the uglyness worth the speedup? I'd > say this should not be done except in very time-critical places... > Pavel This code run on every received beacon, almost on every wifi driver (If i understand what you mean.) --=20 Regards, Oleksij --wPeiUu57NahR2I82nneDslo4JQxIfmkgx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlLZqF4ACgkQHwImuRkmbWkVzQD/RakXROCReQFxlfH2WUvcgm/s h27RY898nl6Txplcd1QA/iBcXdKSu5CM6doc8bhMe1aOLsa1rkxYGv+fLl1IwOwr =oOX1 -----END PGP SIGNATURE----- --wPeiUu57NahR2I82nneDslo4JQxIfmkgx-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.gmx.net ([212.227.17.22]:59165 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbaAQWCO (ORCPT ); Fri, 17 Jan 2014 17:02:14 -0500 Received: from [192.168.1.221] ([93.218.75.192]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MDQI1-1W7HlG06PN-00Gqxb for ; Fri, 17 Jan 2014 23:02:12 +0100 Message-ID: <52D9A85E.8070306@rempel-privat.de> (sfid-20140117_230236_763932_D71D8DEB) Date: Fri, 17 Jan 2014 23:02:06 +0100 From: Oleksij Rempel MIME-Version: 1.0 To: Pavel Machek , Julia Lawall CC: ath9k-devel@lists.ath9k.org, kernel-janitors@vger.kernel.org, ath5k-devel@lists.ath5k.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, "John W. Linville" , users@rt2x00.serialmonkey.com Subject: Re: [PATCH 0/11] use ether_addr_equal_64bits References: <1388427307-8691-1-git-send-email-Julia.Lawall@lip6.fr> <20140117212410.GA13930@amd.pavel.ucw.cz> In-Reply-To: <20140117212410.GA13930@amd.pavel.ucw.cz> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wPeiUu57NahR2I82nneDslo4JQxIfmkgx" Sender: linux-wireless-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wPeiUu57NahR2I82nneDslo4JQxIfmkgx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 17.01.2014 22:24, schrieb Pavel Machek: > On Mon 2013-12-30 19:14:56, Julia Lawall wrote: >> Ether_addr_equal_64bits is more efficient than ether_addr_equal, and c= an be >> used when each argument is an array within a structure that contains a= t >> least two bytes of data beyond the array. >=20 > I mean, yes, it is probably faster, and yes, most structures probably > contain two more bytes, but... is the uglyness worth the speedup? I'd > say this should not be done except in very time-critical places... > Pavel This code run on every received beacon, almost on every wifi driver (If i understand what you mean.) --=20 Regards, Oleksij --wPeiUu57NahR2I82nneDslo4JQxIfmkgx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlLZqF4ACgkQHwImuRkmbWkVzQD/RakXROCReQFxlfH2WUvcgm/s h27RY898nl6Txplcd1QA/iBcXdKSu5CM6doc8bhMe1aOLsa1rkxYGv+fLl1IwOwr =oOX1 -----END PGP SIGNATURE----- --wPeiUu57NahR2I82nneDslo4JQxIfmkgx-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753427AbaAQWCR (ORCPT ); Fri, 17 Jan 2014 17:02:17 -0500 Received: from mout.gmx.net ([212.227.17.20]:62950 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753130AbaAQWCO (ORCPT ); Fri, 17 Jan 2014 17:02:14 -0500 Message-ID: <52D9A85E.8070306@rempel-privat.de> Date: Fri, 17 Jan 2014 23:02:06 +0100 From: Oleksij Rempel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Pavel Machek , Julia Lawall CC: ath9k-devel@venema.h4ckr.net, kernel-janitors@vger.kernel.org, ath5k-devel@venema.h4ckr.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, "John W. Linville" , users@rt2x00.serialmonkey.com Subject: Re: [PATCH 0/11] use ether_addr_equal_64bits References: <1388427307-8691-1-git-send-email-Julia.Lawall@lip6.fr> <20140117212410.GA13930@amd.pavel.ucw.cz> In-Reply-To: <20140117212410.GA13930@amd.pavel.ucw.cz> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wPeiUu57NahR2I82nneDslo4JQxIfmkgx" X-Provags-ID: V03:K0:E6NxAJ4GRQ+Ek0P0NbFYfWPGKIpPiqGm1IloHYWbIW8LTDHaj93 Ku81ZXdJTXF440QK8BvroJJTqHjU39K1gGOYvKIy9aV/0aZ+MV0ptq3dO6rSVVnpEes0cxi Zkf/VRFndlhdb0/5KSiS8gQUjB5PBft4vS5fs5o5nweUfVlJBeO/6mMkrFR+WRJAzsJpdg9 XKM/1Eb1maAiHQx58lIuQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wPeiUu57NahR2I82nneDslo4JQxIfmkgx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 17.01.2014 22:24, schrieb Pavel Machek: > On Mon 2013-12-30 19:14:56, Julia Lawall wrote: >> Ether_addr_equal_64bits is more efficient than ether_addr_equal, and c= an be >> used when each argument is an array within a structure that contains a= t >> least two bytes of data beyond the array. >=20 > I mean, yes, it is probably faster, and yes, most structures probably > contain two more bytes, but... is the uglyness worth the speedup? I'd > say this should not be done except in very time-critical places... > Pavel This code run on every received beacon, almost on every wifi driver (If i understand what you mean.) --=20 Regards, Oleksij --wPeiUu57NahR2I82nneDslo4JQxIfmkgx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlLZqF4ACgkQHwImuRkmbWkVzQD/RakXROCReQFxlfH2WUvcgm/s h27RY898nl6Txplcd1QA/iBcXdKSu5CM6doc8bhMe1aOLsa1rkxYGv+fLl1IwOwr =oOX1 -----END PGP SIGNATURE----- --wPeiUu57NahR2I82nneDslo4JQxIfmkgx--