From: Clemens Ladisch <clemens@ladisch.de>
To: Roman Volkov <v1ron@mail.ru>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v3 04/16] ALSA: Oxygen: Add CS4245_SPI_READ constant
Date: Sat, 18 Jan 2014 11:29:36 +0100 [thread overview]
Message-ID: <52DA5790.3050609@ladisch.de> (raw)
In-Reply-To: <1389971315-3215-4-git-send-email-v1ron@mail.ru>
Roman Volkov wrote:
> The driver needs this constant to perform SPI read operations.
> The shift from CS4245_SPI_ADDRESS and CS4245_SPI_WRITE constants
> removed, since when we need to send two bytes instead of three
> in the SPI packet, we need to shift left by 8 instead of 16.
>
> -#define CS4245_SPI_ADDRESS (0x9e << 16)
> -#define CS4245_SPI_WRITE (0 << 16)
> +#define CS4245_SPI_ADDRESS 0x9e
> +#define CS4245_SPI_WRITE 0
This change alone breaks the driver.
All patches must be self-contained, which is important to be able to
apply the patch series partially during debugging.
Please merge this with the patch that changes the SPI code.
Regards,
Clemens
next prev parent reply other threads:[~2014-01-18 10:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 15:08 [PATCH v3 01/16] ALSA: Oxygen: Add the separate SPI waiting function Roman Volkov
2014-01-17 15:08 ` [PATCH v3 02/16] ALSA: Oxygen: Modify the SPI writing function Roman Volkov
2014-01-17 15:08 ` [PATCH v3 03/16] ALSA: Oxygen: Add mute mask for the OXYGEN_PLAY_ROUTING register Roman Volkov
2014-01-17 15:08 ` [PATCH v3 04/16] ALSA: Oxygen: Add CS4245_SPI_READ constant Roman Volkov
2014-01-18 10:29 ` Clemens Ladisch [this message]
2014-01-17 15:08 ` [PATCH v3 05/16] ALSA: Oxygen: Export oxygen_update_dac_routing symbol Roman Volkov
2014-01-17 15:08 ` [PATCH v3 06/16] ALSA: Oxygen: Change description of the xonar_dg.c file Roman Volkov
2014-01-17 15:08 ` [PATCH v3 07/16] ALSA: Oxygen: Additional definitions for the Xonar DG/DGX card Roman Volkov
2014-01-17 15:08 ` [PATCH v3 08/16] ALSA: Oxygen: Add new CS4245 SPI functions Roman Volkov
2014-01-18 10:36 ` Clemens Ladisch
2014-01-17 15:08 ` [PATCH v3 09/16] ALSA: Oxygen: Modify initialization functions Roman Volkov
2014-01-18 10:50 ` Clemens Ladisch
2014-01-20 14:14 ` Roman Volkov
2014-01-17 15:08 ` [PATCH v3 10/16] ALSA: Oxygen: Modify DAC/ADC parameters function Roman Volkov
2014-01-17 15:08 ` [PATCH v3 11/16] ALSA: Oxygen: Modify adjust_dg_dac_routing function Roman Volkov
2014-01-17 15:08 ` [PATCH v3 12/16] ALSA: Oxygen: Modify CS4245 register dumping function Roman Volkov
2014-01-17 15:08 ` [PATCH v3 13/16] ALSA: Oxygen: Modify suspend, resume, and cleanup functions Roman Volkov
2014-01-17 15:08 ` [PATCH v3 14/16] ALSA: Oxygen: Remove code from the xonar_dg.c file Roman Volkov
2014-01-18 11:08 ` Clemens Ladisch
2014-01-17 15:08 ` [PATCH v3 15/16] ALSA: Oxygen: Additional declarations for the new mixer implementation Roman Volkov
2014-01-17 15:08 ` [PATCH v3 16/16] ALSA: Oxygen: The " Roman Volkov
2014-01-18 10:26 ` [PATCH v3 01/16] ALSA: Oxygen: Add the separate SPI waiting function Clemens Ladisch
2014-01-19 8:10 ` Roman Volkov
2014-01-19 9:39 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DA5790.3050609@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=v1ron@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.