All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tilman Schmidt <tilman@imap.cc>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: davem@davemloft.net, hannes@stressinduktion.org,
	netdev@vger.kernel.org,
	Jakub Zawadzki <darkjames-ws@darkjames.pl>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/3] random32: add prandom_u32_max and convert open coded users
Date: Sun, 19 Jan 2014 14:41:36 +0100	[thread overview]
Message-ID: <52DBD610.7050907@imap.cc> (raw)
In-Reply-To: <1390088431-28657-2-git-send-email-dborkman@redhat.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 19.01.2014 00:40, schrieb Daniel Borkmann:

> @@ -38,6 +37,23 @@ struct rnd_state { u32 prandom_u32_state(struct
> rnd_state *state); void prandom_bytes_state(struct rnd_state
> *state, void *buf, int nbytes);
> 
> +/** + * prandom_u32_max - returns a pseduo-random number in
> interval [0, ep_ro) + * @ep_ro: right open interval endpoint + * +
> * Returns a pseduo-random number that is in interval [0, ep_ro).
> Note + * that the result depends on PRNG being well distributed in
> [0, ~0U] + * u32 space. Here we use maximally equidistributed
> combined Tausworthe + * generator, that is, prandom_u32(). This is
> useful when requesting a + * random index of an array containing
> ep_ro elements, for example. + * + * Returns: pseduo-random number
> in interval [0, ep_ro) + */

The word "pseudo" is consistently mistyped as "pseduo" in this comment.
(Three occurrences.) You may want to correct this before it gets merged.

Thanks,
Tilman

- -- 
Tilman Schmidt                              E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlLb1hAACgkQQ3+did9BuFt4gACeMe9m893fMIapXiZ/AC7BERai
E/cAmgI6r1Uf1EE8reLA6nqd3T/FGWt6
=5qOJ
-----END PGP SIGNATURE-----

  reply	other threads:[~2014-01-19 13:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18 23:40 [PATCH net-next v3 0/3] reciprocal_divide update Daniel Borkmann
2014-01-18 23:40 ` [PATCH net-next v3 1/3] random32: add prandom_u32_max and convert open coded users Daniel Borkmann
2014-01-19 13:41   ` Tilman Schmidt [this message]
2014-01-18 23:40 ` [PATCH net-next v3 2/3] net: introduce reciprocal_scale helper and convert users Daniel Borkmann
2014-01-18 23:40 ` [PATCH net-next v3 3/3] reciprocal_divide: update/correction of the algorithm Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DBD610.7050907@imap.cc \
    --to=tilman@imap.cc \
    --cc=darkjames-ws@darkjames.pl \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hannes@stressinduktion.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.