From: Hannes Reinecke <hare@suse.de>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>,
device-mapper development <dm-devel@redhat.com>
Cc: Mike Snitzer <snitzer@redhat.com>, Alasdair Kergon <agk@redhat.com>
Subject: Re: [PATCH 2/2] dm-multipath: reduce memory pressure during requeuing
Date: Mon, 20 Jan 2014 13:15:09 +0100 [thread overview]
Message-ID: <52DD134D.10202@suse.de> (raw)
In-Reply-To: <11AF7C027C4C02408624617A4986078401024EEB@BPXM12GP.gisp.nec.co.jp>
On 01/20/2014 12:59 PM, Junichi Nomura wrote:
> On 01/17/14 19:42, Hannes Reinecke wrote:
>> @@ -908,19 +910,9 @@ static void multipath_dtr(struct dm_target *ti)
>> static int multipath_map(struct dm_target *ti, struct request *clone,
>> union map_info *map_context)
>> {
>> - int r;
>> struct multipath *m = (struct multipath *) ti->private;
>>
>> - if (set_mapinfo(m, map_context) < 0)
>> - /* ENOMEM, requeue */
>> - return DM_MAPIO_REQUEUE;
>> -
>> - clone->cmd_flags |= REQ_FAILFAST_TRANSPORT;
>> - r = map_io(m, clone, map_context);
>> - if (r < 0 || r == DM_MAPIO_REQUEUE)
>> - clear_mapinfo(m, map_context);
>> -
>> - return r;
>> + return map_io(m, clone, map_context);
>> }
>
> Now multipath_map() is the only caller of map_io() and
> most part of multipath_map() is moved to map_io(),
> there is no reason to separate those functions.
> You could fold map_io() into multipath_map().
>
Yes, I could.
However, I didn't do so (for this patchset)
as this would make reviewing harder.
But yeah, it should be merged.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2014-01-20 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 10:42 [PATCHv2 0/2] dm-multipath: push back requests instead of queueing Hannes Reinecke
2014-01-17 10:42 ` [PATCH 1/2] " Hannes Reinecke
2014-01-20 11:57 ` Junichi Nomura
2014-01-20 15:49 ` Hannes Reinecke
2014-01-21 9:07 ` Junichi Nomura
2014-01-30 15:08 ` Mike Snitzer
2014-01-17 10:42 ` [PATCH 2/2] dm-multipath: reduce memory pressure during requeuing Hannes Reinecke
2014-01-20 11:59 ` Junichi Nomura
2014-01-20 12:15 ` Hannes Reinecke [this message]
2014-01-30 15:09 ` Mike Snitzer
2014-01-18 15:41 ` [PATCHv2 0/2] dm-multipath: push back requests instead of queueing Mike Snitzer
2014-01-30 1:38 ` Mike Snitzer
2014-01-30 6:53 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DD134D.10202@suse.de \
--to=hare@suse.de \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.