All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Longnecker <mlongnecker@nvidia.com>
To: Wei Ni <wni@nvidia.com>, eduardo.valentin@ti.com, rui.zhang@intel.com
Cc: durgadoss.r@intel.com, linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 0/2] Support to tune governor in run time
Date: Mon, 20 Jan 2014 10:58:01 -0800	[thread overview]
Message-ID: <52DD71B9.3080202@nvidia.com> (raw)
In-Reply-To: <1390211732-5853-1-git-send-email-wni@nvidia.com>

Wei,

On 1/20/2014 1:55 AM, Wei Ni wrote:
> This serie can support to turn governor for thermal zone in
> run time.
> Adds avaiable_policies attribute, so the user can get available
> governor policies and change te governor to a new one.
> Adds thermal_update_governor() function, so the thermal platform
> driver can use it to update governor.


I recommend the name thermal_select_governor rather than 
thermal_update_governor.

The name thermal_update_governor sounds like it should be similar to 
thermal_update_zone. But, the two are very different. One is used for 
switching to a new governor and the other is used to trigger thermal 
response for the existing zone.

-Matt

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

      parent reply	other threads:[~2014-01-20 18:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20  9:55 [PATCH v4 0/2] Support to tune governor in run time Wei Ni
2014-01-20  9:55 ` [PATCH v4 1/2] thermal: add available policies attribute Wei Ni
2014-02-27  7:06   ` Zhang Rui
2014-01-20  9:55 ` [PATCH v4 2/2] thermal: add interface to support tune governor in run-time Wei Ni
2014-01-20  9:58   ` Wei Ni
2014-01-20 13:28     ` Eduardo Valentin
2014-02-27  7:10   ` Zhang Rui
2014-02-27  8:00     ` Wei Ni
2014-02-27  8:06       ` Zhang Rui
2014-02-27  8:21         ` Wei Ni
2014-01-20 18:58 ` Matthew Longnecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DD71B9.3080202@nvidia.com \
    --to=mlongnecker@nvidia.com \
    --cc=durgadoss.r@intel.com \
    --cc=eduardo.valentin@ti.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=wni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.