From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Vassili Karpov (malc)" <av1474@comtv.ru>
Subject: Re: [Qemu-devel] [PATCH 1/1] hda-codec: disable streams on reset
Date: Tue, 21 Jan 2014 11:24:47 +0100 [thread overview]
Message-ID: <52DE4AEF.20109@suse.de> (raw)
In-Reply-To: <1390299589-5082-2-git-send-email-kraxel@redhat.com>
Am 21.01.2014 11:19, schrieb Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/audio/hda-codec.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c
> index 07a43bf..986f2a9 100644
> --- a/hw/audio/hda-codec.c
> +++ b/hw/audio/hda-codec.c
> @@ -559,6 +559,21 @@ static int hda_audio_post_load(void *opaque, int version)
> return 0;
> }
>
> +static void hda_audio_reset(DeviceState *dev)
> +{
> + HDAAudioState *a = DO_UPCAST(HDAAudioState, hda.qdev, dev);
[snip]
Can you please follow up with a QOM cast macro to avoid adding more
DO_UPCAST() usages?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2014-01-21 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 10:19 [Qemu-devel] [PULL 0/1] hda-codec: disable streams on reset Gerd Hoffmann
2014-01-21 10:19 ` [Qemu-devel] [PATCH 1/1] " Gerd Hoffmann
2014-01-21 10:24 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DE4AEF.20109@suse.de \
--to=afaerber@suse.de \
--cc=av1474@comtv.ru \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.