Re: [PATCH 0/5] refactor the archive*.bbcalss

[Robert Yang <liezhi.yang@windriver.com>]

Hi Mark,

I've tested the archiver.bbclass with rm_work.bbclasss again, it works for me,
it seems that you only downloaded the archiver.bbclass was not enough, would
you please try this PULL? It is really on oe-core-contrib now:-) And if the
error occurs, would you please show the configuration and error logs ?

git://git.openembedded.org/openembedded-core-contrib rbt/archiver

// Robert

On 01/18/2014 08:26 PM, Martin Jansa wrote:
> On Thu, Jan 16, 2014 at 05:33:20PM +0800, Robert Yang wrote:
>>
>>
>> On 01/16/2014 05:25 PM, Martin Jansa wrote:
>>> On Thu, Jan 16, 2014 at 10:14:30AM +0800, Robert Yang wrote:
>>>>
>>>>
>>>> On 01/16/2014 12:55 AM, Martin Jansa wrote:
>>>>> On Tue, Jan 14, 2014 at 12:20:14AM +0800, Robert Yang wrote:
>>>>>> * The archive*.bbclass didn't work, and there were a few problems, for
>>>>>>      example:
>>>>>>      1) There were a few duplicated code
>>>>>>      2) There was no src_dir.org (or orig), but the diff command still use
>>>>>>         it, and it is not easy to fix this issue if we don't change a lot
>>>>>>         of the code.
>>>>>>      3) It didn't archive the source for the native or gcc
>>>>>>      4) The work flow is not very well
>>>>>>      5) The "subprocess.call('fakeroot cp xxxx'" should be removed
>>>>>>      6) And others ...
>>>>>>
>>>>>> * So that we have to refactor it, the benefits are:
>>>>>>      1) Fix the problems and make it work well.
>>>>>>      2) Reduce more than 400 lines in total.
>>>>>>      3) Make it easy to use.
>>>>>>
>>>>>> // Robert
>>>>>>
>>>>>> The following changes since commit 1b636173ca88e5ccca1992f9a12367a1189fa674:
>>>>>>
>>>>>>      bitbake: toaster: Toaster GUI, generic search, filter and order (2014-01-10 15:20:26 +0000)
>>>>>>
>>>>>> are available in the git repository at:
>>>>>>
>>>>>>      git://git.pokylinux.org/poky-contrib rbt/archiver
>>>>>>      http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=rbt/archiver
>>>>>
>>>>> Can you send pull-request for oe-core?
>>>>>
>>>>
>>>> Here it is:
>>>> git://git.pokylinux.org/poky-contrib rbt/ar_oe
>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=rbt/ar_oe
>>>
>>> This still looks like poky-contrib (so it will download whole
>>> poky-contrib when I add it as remote to oe-core repo).
>>>
>>
>> Sorry, I can't create repo on oe-contrib, seems that I lost my key.
>
> That's sad, you should send new one to khem to replace it, before
> someone else finds your old key.
>
>> How about:
>>
>> git fetch git://git.pokylinux.org/poky-contrib rbt/ar_oe
>
> That still fetches whole poky repo I'm not interested in.
>
> So I've downloaded just archiver.bbclass manually and tested it on my
> use-case, I can confirm that it doesn't remove required file anymore,
> but it seems that there is something terribly broken when used in
> combination with rm_work or multimachine builds.
>
> I haven't debugged it yet, but 2nd build (in the same directory) with
> this new archiver included almost every recipe failed in do_patch task.
>
>>>> // Robert
>>>>
>>>>>> Robert Yang (5):
>>>>>>      classes/archive*.bbclass: remove archive-*-source.bbclass
>>>>>>      archiver.bbclass: refactor it
>>>>>>      package_rpm.bbclass: archive the source to srpm package
>>>>>>      archiver.bbclass: move a few code to copyleft_compliance.bbclass
>>>>>>      local.conf.sample.extended: update for the archiver
>>>>>>
>>>>>>     meta-yocto/conf/local.conf.sample.extended     |  72 +--
>>>>>>     meta/classes/archive-configured-source.bbclass |  65 ---
>>>>>>     meta/classes/archive-original-source.bbclass   |  65 ---
>>>>>>     meta/classes/archive-patched-source.bbclass    |  65 ---
>>>>>>     meta/classes/archiver.bbclass                  | 723 ++++++++-----------------
>>>>>>     meta/classes/copyleft_compliance.bbclass       |  55 +-
>>>>>>     meta/classes/package_rpm.bbclass               |  31 +-
>>>>>>     7 files changed, 316 insertions(+), 760 deletions(-)
>>>>>>     delete mode 100644 meta/classes/archive-configured-source.bbclass
>>>>>>     delete mode 100644 meta/classes/archive-original-source.bbclass
>>>>>>     delete mode 100644 meta/classes/archive-patched-source.bbclass
>>>>>>
>>>>>> --
>>>>>> 1.8.3.1
>>>>>>
>>>>>> _______________________________________________
>>>>>> Openembedded-core mailing list
>>>>>> Openembedded-core@lists.openembedded.org
>>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>>
>>>
>