From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47920)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W5Ywm-0006QO-Lh
	for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:52:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W5Ywe-0007hB-8x
	for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:52:44 -0500
Received: from mail-qe0-x22a.google.com ([2607:f8b0:400d:c02::22a]:47135)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W5Ywe-0007h3-4D
	for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:52:36 -0500
Received: by mail-qe0-f42.google.com with SMTP id i11so3991610qej.29
	for <qemu-devel@nongnu.org>; Tue, 21 Jan 2014 02:52:35 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52DE516D.8070301@redhat.com>
Date: Tue, 21 Jan 2014 11:52:29 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1390236074-21533-1-git-send-email-ehabkost@redhat.com>
	<1390236074-21533-5-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1390236074-21533-5-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/7] target-i386: kvm_cpu_fill_host(): No
 need to check xlevel2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

Il 20/01/2014 17:41, Eduardo Habkost ha scritto:
> -    eax = kvm_arch_get_supported_cpuid(s, 0xC0000000, 0, R_EAX);
> -    if (eax >= 0xC0000001) {
> -        /* Support VIA max extended level */
> -        x86_cpu_def->xlevel2 = eax;
> -        x86_cpu_def->features[FEAT_C000_0001_EDX] =
> -                kvm_arch_get_supported_cpuid(s, 0xC0000001, 0, R_EDX);
> -    }
> +    x86_cpu_def->xlevel2 =
> +        kvm_arch_get_supported_cpuid(s, 0xC0000000, 0, R_EAX);
> +    /* Support VIA max extended level */
> +    x86_cpu_def->features[FEAT_C000_0001_EDX] =
> +        kvm_arch_get_supported_cpuid(s, 0xC0000001, 0, R_EDX);
>  

I'm removing this comment before applying the patch (I believe the
comment was not really grammatical, and it meant something like "VIA max
extended level supported").

Paolo