From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Subject: Re: [PATCH 1/7] mmc: core add the property for hs200 Date: Tue, 21 Jan 2014 21:20:32 +0900 Message-ID: <52DE6610.4030702@samsung.com> References: <52DE4916.4090603@samsung.com> <3339329.LQJLrAHSHx@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:17983 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754274AbaAUMUJ (ORCPT ); Tue, 21 Jan 2014 07:20:09 -0500 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MZR00EXV3LJ3J60@mailout1.samsung.com> for linux-mmc@vger.kernel.org; Tue, 21 Jan 2014 21:20:08 +0900 (KST) In-reply-to: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson , Arnd Bergmann , Jaehoon Chung Cc: "linux-mmc@vger.kernel.org" , Chris Ball , Seungwon Jeon , Guennadi Liakhovetski On 01/21/2014 09:12 PM, Ulf Hansson wrote: > On 21 January 2014 11:30, Arnd Bergmann wrote: >> On Tuesday 21 January 2014 19:16:54 Jaehoon Chung wrote: >>> caps2-mmc-hs200-1.8v and caps2-mmc-hs200-1.2v can be used to the general capability. >>> >>> Signed-off-by: Jaehoon Chung >>> --- >>> drivers/mmc/core/host.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c >>> index 49bc403..96ac4c1 100644 >>> --- a/drivers/mmc/core/host.c >>> +++ b/drivers/mmc/core/host.c >>> @@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host) >>> host->pm_caps |= MMC_PM_KEEP_POWER; >>> if (of_find_property(np, "enable-sdio-wakeup", &len)) >>> host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ; >>> + if (of_find_property(np, "caps2-mmc-hs200-1_8v", NULL)) >>> + host->caps2 |= MMC_CAP2_HS200_1_8V_SDR; >>> + if (of_find_property(np, "caps2-mmc-hs200-1_2v", NULL)) >>> + host->caps2 |= MMC_CAP2_HS200_1_2V_SDR; >>> >>> return 0; >> >> If we do this, the strings also need to be documented in >> bindings/mmc/mmc.txt. >> >> Unfortunately, the names are not particularly intuitive (the caps2 >> part in particular), but it's probably better to stick with that >> now. > > I would prefer to remove "caps2" from the property name. > > Going forward and cleaning up all the non needed caps flags, could > mean we may want to move caps2 flags into caps flags, I guess. This > would not be suitable if we decide to name the property as above. Agreed,caps2 flags can be changed in future. I will remove the "caps2" from name. And i will add the document in binding/mmc/mmc.txt at next patch. Best Regards, Jaehoon Chung > > Kind regards > Uffe > >> >> Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >