All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Martin Husemann <martin@duskware.de>, qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD
Date: Tue, 21 Jan 2014 16:42:32 +0100	[thread overview]
Message-ID: <52DE9568.7020900@suse.de> (raw)
In-Reply-To: <20140118134723.GA20716@mail.duskware.de>

Am 18.01.2014 14:47, schrieb Martin Husemann:
>  Do not rely on int8_t (and friends) not being preprocessor
>  symbols (or symbols expanding to themselves). On NetBSD (for example) the
>  glue(u, SDATA_TYPE) results in u__int8_t, which is undefined. There is no way
>  to stop cpp expanding inner macros, so just add the few lines explicitly and
>  get rid of the magic.
> 
> Signed-off-by: Martin Husemann <martin@NetBSD.org>

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Martin Husemann <martin@duskware.de>, qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD
Date: Tue, 21 Jan 2014 16:42:32 +0100	[thread overview]
Message-ID: <52DE9568.7020900@suse.de> (raw)
In-Reply-To: <20140118134723.GA20716@mail.duskware.de>

Am 18.01.2014 14:47, schrieb Martin Husemann:
>  Do not rely on int8_t (and friends) not being preprocessor
>  symbols (or symbols expanding to themselves). On NetBSD (for example) the
>  glue(u, SDATA_TYPE) results in u__int8_t, which is undefined. There is no way
>  to stop cpp expanding inner macros, so just add the few lines explicitly and
>  get rid of the magic.
> 
> Signed-off-by: Martin Husemann <martin@NetBSD.org>

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  parent reply	other threads:[~2014-01-21 15:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  8:55 [Qemu-devel] qemu 1.7.0 does not build on NetBSD (patch) Martin Husemann
2013-12-17 10:15 ` Paolo Bonzini
2014-01-15 12:33   ` Paolo Bonzini
2014-01-18 13:47     ` [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD Martin Husemann
2014-01-18 13:59       ` Peter Maydell
2014-01-21 15:38         ` Richard Henderson
2014-01-21 15:42       ` Andreas Färber [this message]
2014-01-21 15:42         ` Andreas Färber
2014-01-21 18:11       ` [Qemu-trivial] " Michael Tokarev
2014-01-21 18:11         ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DE9568.7020900@suse.de \
    --to=afaerber@suse.de \
    --cc=martin@duskware.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.