All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@open-mesh.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	Antonio Quartulli <antonio@meshcoding.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 1/5] cfg80211: export minstrel best rate information through get_station()
Date: Tue, 21 Jan 2014 17:09:14 +0100	[thread overview]
Message-ID: <52DE9BAA.6020205@open-mesh.com> (raw)
In-Reply-To: <1390320014.6199.61.camel@jlt4.sipsolutions.net>

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On 21/01/14 17:00, Johannes Berg wrote:
> On Tue, 2014-01-21 at 12:09 +0100, Antonio Quartulli wrote:
> 
>> + * @prob: probability of success of this birate
> 
> typo: bitrate
> 
>> +struct cfg80211_minstrel_rate_info {
>> +	u32 bitrate;
>> +	u32 prob;
>> +};
> 
> Do you actually care about this, rather than bitrate*prob, ie. something
> like "expected throughput"? 

Right now this is the way how we use it in the batman-adv code..but we
may decide to change it for some reason. This is why I preferred to keep
the two values separated.

> Actually this isn't expected throughput, but
> wouldn't something like expected throughput make even more sense?

How should I obtain that if not with the previous operation (bitrate*prob)?


-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-01-21 16:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-21 11:09 [RFC 0/5] Export Minstrel best API information via get_station() Antonio Quartulli
2014-01-21 11:09 ` [RFC 1/5] cfg80211: export minstrel best rate information through get_station() Antonio Quartulli
2014-01-21 16:00   ` Johannes Berg
2014-01-21 16:09     ` Antonio Quartulli [this message]
2014-01-21 16:18       ` Johannes Berg
2014-01-21 16:32         ` Antonio Quartulli
2014-01-22 14:41           ` Antonio Quartulli
2014-01-22 14:43             ` Johannes Berg
2014-01-22 18:32               ` Thomas Hühn
2014-01-22 18:44                 ` Antonio Quartulli
2014-01-21 11:09 ` [RFC 2/5] mac80211: export minstrel best rate information in set_sta_info() Antonio Quartulli
2014-01-21 16:01   ` Johannes Berg
2014-01-21 11:09 ` [RFC 3/5] mac80211: minstrel - implement get_minstrel_best_rate() API Antonio Quartulli
2014-01-21 11:09 ` [RFC 4/5] mac80211: minstrel_ht " Antonio Quartulli
2014-01-21 11:09 ` [RFC 5/5] cfg80211: implement cfg80211_get_station Antonio Quartulli
2014-01-21 16:03   ` Johannes Berg
2014-01-21 16:07     ` Antonio Quartulli
2014-01-21 13:52 ` [RFC 0/5] Export Minstrel best API information via get_station() Thomas Hühn
2014-01-21 15:28   ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-01-21 15:28     ` Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DE9BAA.6020205@open-mesh.com \
    --to=antonio@open-mesh.com \
    --cc=antonio@meshcoding.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.