All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/3] block: resize backing file image during offline commit, if necessary
Date: Tue, 21 Jan 2014 09:41:19 -0700	[thread overview]
Message-ID: <52DEA32F.9070909@redhat.com> (raw)
In-Reply-To: <afa1989a2f131af7fd6657608b1adc6419eb5eb1.1390321064.git.jcody@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

On 01/21/2014 09:31 AM, Jeff Cody wrote:
> Currently, if an image file is logically larger than its backing file,
> commiting it via 'qemu-img commit' will fail.

s/commiting/committing/

> 
> For instance, if we have a base image with a virtual size 10G, and a
> snapshot image of size 20G, then committing the snapshot offline with
> 'qemu-img commit' will likely fail.
> 
> This will automatically attempt to resize the base image, if the
> snapshot image to be committed is larger.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  block.c | 23 ++++++++++++++++++++---
>  1 file changed, 20 insertions(+), 3 deletions(-)
> 

The commit message change is trivial, so:

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2014-01-21 16:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-21 16:31 [Qemu-devel] [PATCH v2 0/3] block: commits of snapshots larger than backing files Jeff Cody
2014-01-21 16:31 ` [Qemu-devel] [PATCH v2 1/3] block: resize backing file image during offline commit, if necessary Jeff Cody
2014-01-21 16:41   ` Eric Blake [this message]
2014-01-22  1:58   ` Fam Zheng
2014-01-21 16:31 ` [Qemu-devel] [PATCH v2 2/3] block: resize backing image during active layer commit, if needed Jeff Cody
2014-01-21 17:00   ` Eric Blake
2014-01-22  1:54   ` Fam Zheng
2014-01-22  4:28     ` Jeff Cody
2014-01-21 16:31 ` [Qemu-devel] [PATCH v2 3/3] block: update block commit documentation regarding image truncation Jeff Cody
2014-01-21 16:37   ` Eric Blake
2014-01-22  2:03   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DEA32F.9070909@redhat.com \
    --to=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.