From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 21 Jan 2014 18:13:13 +0100 (CET) Received: from multi.imgtec.com ([194.200.65.239]:31468 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6823127AbaAURNLaWbui (ORCPT ); Tue, 21 Jan 2014 18:13:11 +0100 Message-ID: <52DEAAA0.5060801@imgtec.com> Date: Tue, 21 Jan 2014 17:13:04 +0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: John Crispin CC: Subject: Re: [PATCH] MIPS: Add P5600 PRid and probe support References: <1390315820-15723-1-git-send-email-james.hogan@imgtec.com> <52DEA5D9.2000904@phrozen.org> In-Reply-To: <52DEA5D9.2000904@phrozen.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.65] X-SEF-Processed: 7_3_0_01192__2014_01_21_17_13_05 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 39040 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: james.hogan@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi John, On 21/01/14 16:52, John Crispin wrote: >> Add a Processor ID for the P5600 core and a case in cpu_probe_mips() for >> it. The cputype is set to CPU_PROAPTIV for now as it is in the same >> range of cores as proAptiv and doesn't currently need to be >> distinguished from it in the kernel. > The "currently" in that sentence tells me that you expect there to be a > need to distinguish it in future ? More an "I don't know at this stage whether there'll be a need to distinguish them in future". Even glancing at perf counters they look the same (but I haven't checked every one). > If this is the case, then the code should be added now rather than > correcting the code later. > I immediately had to think of the 1074k vs 74k patch that is in > linux-mti-3.10 and was posted a few days ago. Okay, fair enough, It does no real harm to re-do with a different CPU id. Thanks James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from multi.imgtec.com ([194.200.65.239]:31468 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6823127AbaAURNLaWbui (ORCPT ); Tue, 21 Jan 2014 18:13:11 +0100 Message-ID: <52DEAAA0.5060801@imgtec.com> Date: Tue, 21 Jan 2014 17:13:04 +0000 From: James Hogan MIME-Version: 1.0 Subject: Re: [PATCH] MIPS: Add P5600 PRid and probe support References: <1390315820-15723-1-git-send-email-james.hogan@imgtec.com> <52DEA5D9.2000904@phrozen.org> In-Reply-To: <52DEA5D9.2000904@phrozen.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: John Crispin Cc: linux-mips@linux-mips.org Message-ID: <20140121171304.yg8l_zZ1smJ9zBbEkxoBTkadY4oTuUoebZ8PzK_MqqE@z> Hi John, On 21/01/14 16:52, John Crispin wrote: >> Add a Processor ID for the P5600 core and a case in cpu_probe_mips() for >> it. The cputype is set to CPU_PROAPTIV for now as it is in the same >> range of cores as proAptiv and doesn't currently need to be >> distinguished from it in the kernel. > The "currently" in that sentence tells me that you expect there to be a > need to distinguish it in future ? More an "I don't know at this stage whether there'll be a need to distinguish them in future". Even glancing at perf counters they look the same (but I haven't checked every one). > If this is the case, then the code should be added now rather than > correcting the code later. > I immediately had to think of the 1074k vs 74k patch that is in > linux-mti-3.10 and was posted a few days ago. Okay, fair enough, It does no real harm to re-do with a different CPU id. Thanks James