From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] tools: mkimage: add support for gpimage format
Date: Tue, 21 Jan 2014 16:23:54 -0500 [thread overview]
Message-ID: <52DEE56A.7050103@ti.com> (raw)
In-Reply-To: <20140121193426.D2D8138201D@gemini.denx.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/21/2014 02:34 PM, Wolfgang Denk wrote:
> Dear Murali,
>
> In message
> <3E54258959B69E4282D79E01AB1F32B70466CE4A@DFLE11.ent.ti.com> you
> wrote:
>>
>>>> + if (do_swap32) { + gph_size = gpimage_swap32(gph->size); +
>>>> gph_load_addr = gpimage_swap32(gph->load_addr); + } else { +
>>>> gph_size = gph->size; + gph_load_addr = gph->load_addr; + }
>>>
>>> I think it should be possible top write this code in such a way
>>> that you can avoid both the if- else and passing the do_swap32
>>> parameter. It is my impression that the whole endianess
>>> handling needs some refinemant.
>>>
>>> Actually I cannot see a place where do_swap32=0 is used..
>>
>> This is done to keep the omapimage usage of this variable.
>
> Is this actually used? It appear the omapimage handling would set
> do_swap32=1 only when imagename == "byteswap" (see
> "tools/omapimage.c"). Is this a practical usecase anywhere?
In omapimage? Yes. On gpimage? I doubt it.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJS3uVpAAoJENk4IS6UOR1WzoUP/1SFGSUOUV+T9F/2qFTpftNf
Wt/3d+Pel7YFxzswZcj2Tmgdf8dpN6/3VUXByRxvru7MPOXvKLkVgr6m94s0a5lH
T6i/492u5H+BdHVBXfQlSqULMOExWk6CEtRzIydEqrLmS6PehTCcuvDLrPYBeegk
xncOap21YoPzfA8cvFhZ8y+ucVCbS7U/zHhLoNw69pc+AW0aZjTzOgEBdTHagkCX
KV4WxfTAmBnOl+u7Pn38GPU9zfvVre4UDINiVN+/Qr6vru9B5MYAUIdOAb9a9O6x
a00Yoh9xRfW9PbAyguW+EoURX5aIhoLFTTEDJ6HKyvmt4qhw+riG2/GrkXaRYJPD
kifL1wfkQOYHD5E59soJ5XV1GqIfocvEO4aCmdNmizJlXsjlLNgeIklRdv1dA1Dt
f2RaSlip/B1+joLyxthCqG9VfU2PKz3m6+Wy2SxIO1lf2cGbgKFJY6oGi5gGpTCy
+TbpZx+1ltF36zKIFIdKqHc9w9xMc05VYZfSqfOBmGe3NTuR1tRB2FvrBdEYOqIW
LNOLAz0od/mTxG0tiP+BkGNx+ZwYMhck3zZIXdWBOmCigu0RFFG5SSIF0uGoAv/z
Th3y3qhCDJ2YGef+euWJvQwz1oxXb7WdV23p+zmDPSyQUpl0eKDyiMrq0ooo/TZI
pplaUIOfbd5sumSZC4E2
=X3XI
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-01-21 21:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 22:10 [U-Boot] [PATCH 0/5] preparation to intriduce keystone support Murali Karicheri
2014-01-20 22:10 ` [U-Boot] [PATCH 1/5] tools: mkimage: add support for gpimage format Murali Karicheri
2014-01-20 22:46 ` Wolfgang Denk
2014-01-20 22:56 ` Tom Rini
[not found] ` <3E54258959B69E4282D79E01AB1F32B70466CE4A@DFLE11.ent.ti.com>
2014-01-21 19:34 ` Wolfgang Denk
2014-01-21 21:23 ` Tom Rini [this message]
2014-01-20 22:10 ` [U-Boot] [PATCH 2/5] ubifs: fix checkpatch warning Murali Karicheri
2014-02-21 19:56 ` [U-Boot] [U-Boot,2/5] " Tom Rini
2014-01-20 22:10 ` [U-Boot] [PATCH 3/5] ubifs: return filesize from ubifs load operations Murali Karicheri
2014-02-21 19:14 ` Tom Rini
2014-01-20 22:10 ` [U-Boot] [PATCH 4/5] arm: add support for arch timer Murali Karicheri
2014-01-20 22:50 ` Wolfgang Denk
[not found] ` <3E54258959B69E4282D79E01AB1F32B70466CE69@DFLE11.ent.ti.com>
2014-01-21 19:35 ` Wolfgang Denk
2014-01-20 22:10 ` [U-Boot] [PATCH 5/5] NAND: DaVinci: allow forced disable of subpage writes Murali Karicheri
2014-01-20 22:51 ` Wolfgang Denk
[not found] ` <3E54258959B69E4282D79E01AB1F32B70466CE81@DFLE11.ent.ti.com>
2014-01-21 19:37 ` Wolfgang Denk
2014-01-22 20:48 ` Scott Wood
[not found] ` <3E54258959B69E4282D79E01AB1F32B704672974@DFLE11.ent.ti.com>
2014-02-13 0:00 ` Scott Wood
2014-02-18 14:57 ` Tom Rini
2014-02-19 23:33 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DEE56A.7050103@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.