From: Waiman Long <waiman.long@hp.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Arnd Bergmann <arnd@arndb.de>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michel Lespinasse <walken@google.com>,
Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
George Spelvin <linux@horizon.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
"Chandramouleeswaran, Aswin" <aswin@hp.com>,
Scott J Norton <scott.norton@hp.com>
Subject: Re: [PATCH v9 3/5] qrwlock, x86 - Treat all data type not bigger than long as atomic in x86
Date: Tue, 21 Jan 2014 23:42:32 -0500 [thread overview]
Message-ID: <52DF4C38.7040003@hp.com> (raw)
In-Reply-To: <CA+55aFzyww_kwU36jYk=LUtxzPUU76xgnQEOUTqGMFNe80sOZA@mail.gmail.com>
On 01/21/2014 07:31 PM, Linus Torvalds wrote:
> On Tue, Jan 21, 2014 at 8:09 AM, Waiman Long<waiman.long@hp.com> wrote:
>> include/linux/compiler.h:
>>
>> #ifndef __native_word
>> # ifdef __arch_native_word(t)
>> # define __native_word(t) __arch_native_word(t)
>> # else
>> # define __native_word(t) (sizeof(t) == sizeof(int) || sizeof(t) == siizeof(long))
>> # endif
>> #endif
> Do we even really need this?
>
> I'd suggest removing it entirely. You might want to retain the whole
>
> compiletime_assert_atomic_type()
>
> thing on purely the alpha side, but then it's all inside just the
> alpha code, without any need for this "native_word" thing.
>
> And if somebody tries to do a "smp_store_release()" on a random
> structure or union, do we care? We're not some nanny state that wants
> to give nice warnings for insane code.
>
> Linus
That sounds good to me too. Peter, what do you think about this?
-Longman
next prev parent reply other threads:[~2014-01-22 4:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 4:44 [PATCH v9 0/5] qrwlock: Introducing a queue read/write lock implementation Waiman Long
2014-01-15 4:44 ` [PATCH v9 1/5] qrwlock: A " Waiman Long
2014-01-20 15:21 ` Peter Zijlstra
2014-01-21 15:58 ` Waiman Long
2014-01-21 15:58 ` Waiman Long
2014-01-15 4:44 ` [PATCH v9 2/5] qrwlock x86: Enable x86 to use queue read/write lock Waiman Long
2014-01-20 16:08 ` Peter Zijlstra
2014-01-20 16:16 ` Steven Rostedt
2014-01-21 16:00 ` Waiman Long
2014-01-21 16:00 ` Waiman Long
2014-01-15 4:44 ` [PATCH v9 3/5] qrwlock, x86 - Treat all data type not bigger than long as atomic in x86 Waiman Long
2014-01-20 15:03 ` Peter Zijlstra
2014-01-21 15:36 ` Waiman Long
2014-01-21 15:36 ` Waiman Long
2014-01-21 15:39 ` Peter Zijlstra
2014-01-21 16:09 ` Waiman Long
2014-01-22 0:31 ` Linus Torvalds
2014-01-22 4:42 ` Waiman Long [this message]
2014-01-22 8:01 ` Peter Zijlstra
2014-01-22 12:09 ` Ingo Molnar
2014-01-22 12:13 ` Peter Zijlstra
2014-01-22 13:09 ` Ingo Molnar
2014-01-27 17:09 ` Paul E. McKenney
2014-01-15 4:44 ` [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock() Waiman Long
2014-01-20 3:39 ` Paul E. McKenney
2014-01-20 15:18 ` Peter Zijlstra
2014-01-21 15:45 ` Waiman Long
2014-01-21 15:45 ` Waiman Long
2014-01-21 15:49 ` Peter Zijlstra
2014-01-15 4:44 ` [PATCH v9 5/5] qrwlock: Use the mcs_spinlock helper functions for MCS queuing Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DF4C38.7040003@hp.com \
--to=waiman.long@hp.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=aswin@hp.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.