Re: [Qemu-devel] [PATCH] drive-mirror: fix memory leak

[Zhang Min <rudy.zhangmin@huawei.com>]

Hi,Fam
I am very sorry for this patch,because I use Outlook to send this email.
Later on, I will submit the patch by git send-email again.

On 2014/1/22 11:41, Fam Zheng wrote:
> Hi,
> 
> The patch itself looks good to me, but it has too many extra empty lines
> interleaved. Please try to use "git send-email" to submit your patches, for
> more information, follow the instructions as in:
> 
> http://wiki.qemu.org/Contribute/SubmitAPatch
> 
> On Tue, 01/21 11:43, Chentao (Boby) wrote:
>> In the function mirror_iteration() -> qemu_iovec_init(), it alloc memory for op->qiov.iov, when the write request call back,
> 
> s/alloc/allocates/
> s/call back/calls back/
> 
>>
>>
>>
>> but in the function mirror_iteration_done(), it only free the op, not free the op->qiov.iov, so this cause memory leak.
> 
> s/free/frees/
> s/cause/causes/
> 
>>
>>
>>
>> Signed-off-by: Zhang Min <rudy.zhangmin@huawei.com<mailto:rudy.zhangmin@huawei.com>>
> 
> Unnecessary <mailto:> notation here.
> 
>>
>> ---
>>
>> block/mirror.c |    1 +
>>
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>>
>>
>> diff --git a/block/mirror.c b/block/mirror.c index 2932bab..9840840 100644
>>
>> --- a/block/mirror.c
>>
>> +++ b/block/mirror.c
>>
>> @@ -96,6 +96,7 @@ static void mirror_iteration_done(MirrorOp *op, int ret)
>>
>>          bitmap_set(s->cow_bitmap, chunk_num, nb_chunks);
>>
>>      }
>>
>>
>>
>> +    g_free(op->qiov.iov);
>>
>>      g_slice_free(MirrorOp, op);
>>
>>      qemu_coroutine_enter(s->common.co, NULL);  }
>>
>> --
>>
>>
> 
> 

-- 

Zhang Min