From: Jeff Liu <jeff.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/199: enforce v4 superblock format for test
Date: Wed, 22 Jan 2014 17:53:07 +0800 [thread overview]
Message-ID: <52DF9503.6080708@oracle.com> (raw)
In-Reply-To: <1390302628-19020-1-git-send-email-david@fromorbit.com>
On 01/21 2014 19:10 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> This test relies of the contents of the sb_features2 field being
> known. Make sure ot clear allt eh MKFS_OPTIONS and ensure that we
> direct mkfs to create only the simplest of featuresets to test this
> functionality.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> tests/xfs/199 | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/xfs/199 b/tests/xfs/199
> index 1d64e02..c1b5962 100755
> --- a/tests/xfs/199
> +++ b/tests/xfs/199
> @@ -49,7 +49,10 @@ _supported_os Linux
>
> _require_scratch
>
> -_scratch_mkfs_xfs -l lazy-count=1 >/dev/null 2>&1
> +# clear any mkfs options so taht we can directly specify the options we need to
^^^
a typo...
> +# be able to test the features bitmask behaviour correctly.
> +MKFS_OPTIONS=
> +_scratch_mkfs_xfs -l lazy-count=1 -i projid32bit=0 >/dev/null 2>&1
>
> #
> # Print the current flags. Just a dummy so that the test breaks
Looks good to me.
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-01-22 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 11:10 [PATCH] xfs/199: enforce v4 superblock format for test Dave Chinner
2014-01-22 9:53 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DF9503.6080708@oracle.com \
--to=jeff.liu@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.