From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Subject: Re: [PATCH 3/6] drm/radeon: Use new drm debugfs file helper Date: Wed, 22 Jan 2014 11:11:10 +0100 Message-ID: <52DF993E.6070203@amd.com> References: <1389708847-25038-1-git-send-email-benjamin.widawsky@intel.com> <1390336402-2049-1-git-send-email-benjamin.widawsky@intel.com> <1390336402-2049-3-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from co1outboundpool.messaging.microsoft.com (co1ehsobe002.messaging.microsoft.com [216.32.180.185]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DC61FB758 for ; Wed, 22 Jan 2014 02:42:03 -0800 (PST) In-Reply-To: <1390336402-2049-3-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Ben Widawsky , DRI Development Cc: Ben Widawsky List-Id: dri-devel@lists.freedesktop.org QW0gMjEuMDEuMjAxNCAyMTozMywgc2NocmllYiBCZW4gV2lkYXdza3k6Cj4gVGhlIGRlYnVnZnMg aGVscGVyIGR1cGxpY2F0ZXMgdGhlIGZ1bmN0aW9uYWxpdHkgdXNlZCBieSBBcm1hZGEsIHNvIGxl dCdzCj4ganVzdCB1c2UgdGhhdC4KPgo+IFdBUk5JTkc6IG9ubHkgY29tcGlsZSB0ZXN0ZWQKPgo+ IENjOiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gU2lnbmVk LW9mZi1ieTogQmVuIFdpZGF3c2t5IDxiZW5AYndpZGF3c2submV0Pgo+IC0tLQo+ICAgZHJpdmVy cy9ncHUvZHJtL3JhZGVvbi9yYWRlb24uaCAgICAgfCAgNSAtLS0tLQo+ICAgZHJpdmVycy9ncHUv ZHJtL3JhZGVvbi9yYWRlb25fdHRtLmMgfCA0MyArKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDIyIGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uLmgg Yi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbi5oCj4gaW5kZXggYzU1MTljYS4uY2VlYzQ2 OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbi5oCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb24uaAo+IEBAIC00MTgsMTEgKzQxOCw2IEBAIHN0 cnVjdCByYWRlb25fbW1hbiB7Cj4gICAJc3RydWN0IHR0bV9ib19kZXZpY2UJCWJkZXY7Cj4gICAJ Ym9vbAkJCQltZW1fZ2xvYmFsX3JlZmVyZW5jZWQ7Cj4gICAJYm9vbAkJCQlpbml0aWFsaXplZDsK PiAtCj4gLSNpZiBkZWZpbmVkKENPTkZJR19ERUJVR19GUykKPiAtCXN0cnVjdCBkZW50cnkJCQkq dnJhbTsKPiAtCXN0cnVjdCBkZW50cnkJCQkqZ3R0Owo+IC0jZW5kaWYKPiAgIH07Cj4gICAKPiAg IC8qIGJvIHZpcnR1YWwgYWRkcmVzcyBpbiBhIHNwZWNpZmljIHZtICovCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX3R0bS5jIGIvZHJpdmVycy9ncHUvZHJtL3Jh ZGVvbi9yYWRlb25fdHRtLmMKPiBpbmRleCA3N2Y1YjBjLi5jZjdjYWYyIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX3R0bS5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3JhZGVvbi9yYWRlb25fdHRtLmMKPiBAQCAtOTcxLDI3ICs5NzEsMzQgQEAgc3RhdGljIGNv bnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgcmFkZW9uX3R0bV9ndHRfZm9wcyA9IHsKPiAgIAku bGxzZWVrID0gZGVmYXVsdF9sbHNlZWsKPiAgIH07Cj4gICAKPiArc3RhdGljIGNvbnN0IHN0cnVj dCByYWRlb25fZGVidWdmc19maWxlcyB7Cj4gKwljb25zdCBjaGFyICpuYW1lOwo+ICsJY29uc3Qg c3RydWN0IGZpbGVfb3BlcmF0aW9ucyAqZm9wczsKPiArfSByYWRlb25fZGVidWdmc19maWxlc1td ID0gewo+ICsJeyJyYWRlb25fdnJhbSIsICZyYWRlb25fdHRtX3ZyYW1fZm9wc30sCj4gKwl7InJh ZGVvbl9ndHQiLCAmcmFkZW9uX3R0bV9ndHRfZm9wc30sCj4gK307Cj4gICAjZW5kaWYKPiAgIAo+ ICAgc3RhdGljIGludCByYWRlb25fdHRtX2RlYnVnZnNfaW5pdChzdHJ1Y3QgcmFkZW9uX2Rldmlj ZSAqcmRldikKPiAgIHsKPiAgICNpZiBkZWZpbmVkKENPTkZJR19ERUJVR19GUykKPiAgIAl1bnNp Z25lZCBjb3VudDsKPiArCWludCBpLCByZXQ7Cj4gICAKPiAgIAlzdHJ1Y3QgZHJtX21pbm9yICpt aW5vciA9IHJkZXYtPmRkZXYtPnByaW1hcnk7Cj4gLQlzdHJ1Y3QgZGVudHJ5ICplbnQsICpyb290 ID0gbWlub3ItPmRlYnVnZnNfcm9vdDsKPiAtCj4gLQllbnQgPSBkZWJ1Z2ZzX2NyZWF0ZV9maWxl KCJyYWRlb25fdnJhbSIsIFNfSUZSRUcgfCBTX0lSVUdPLCByb290LAo+IC0JCQkJICByZGV2LCAm cmFkZW9uX3R0bV92cmFtX2ZvcHMpOwo+IC0JaWYgKElTX0VSUihlbnQpKQo+IC0JCXJldHVybiBQ VFJfRVJSKGVudCk7Cj4gLQlyZGV2LT5tbWFuLnZyYW0gPSBlbnQ7Cj4gLQo+IC0JZW50ID0gZGVi dWdmc19jcmVhdGVfZmlsZSgicmFkZW9uX2d0dCIsIFNfSUZSRUcgfCBTX0lSVUdPLCByb290LAo+ IC0JCQkJICByZGV2LCAmcmFkZW9uX3R0bV9ndHRfZm9wcyk7Cj4gLQlpZiAoSVNfRVJSKGVudCkp Cj4gLQkJcmV0dXJuIFBUUl9FUlIoZW50KTsKPiAtCXJkZXYtPm1tYW4uZ3R0ID0gZW50Owo+ICsJ c3RydWN0IGRlbnRyeSAqcm9vdCA9IG1pbm9yLT5kZWJ1Z2ZzX3Jvb3Q7Cj4gKwo+ICsJZm9yIChp ID0gMDsgaSA8IEFSUkFZX1NJWkUocmFkZW9uX2RlYnVnZnNfZmlsZXMpOyBpKyspIHsKPiArCQly ZXQgPSBkcm1fZGVidWdmc19jcmVhdGVfZmlsZShyb290LCBtaW5vciwKPiArCQkJCQkgICAgICBy YWRlb25fZGVidWdmc19maWxlc1tpXS5uYW1lLAo+ICsJCQkJCSAgICAgIHJhZGVvbl9kZWJ1Z2Zz X2ZpbGVzW2ldLmZvcHMsCj4gKwkJCQkJICAgICAgU19JRlJFRyB8IFNfSVdVU1IpOwo+ICsJCWlm IChyZXQpIHsKPiArCQkJcmFkZW9uX3R0bV9kZWJ1Z2ZzX2ZpbmkocmRldik7Cj4gKwkJCXJldHVy biByZXQ7Cj4gKwkJfQo+ICsJfQo+ICAgCj4gICAJY291bnQgPSBBUlJBWV9TSVpFKHJhZGVvbl90 dG1fZGVidWdmc19saXN0KTsKPiAgIAo+IEBAIC0xMDEwLDExICsxMDE3LDEzIEBAIHN0YXRpYyBp bnQgcmFkZW9uX3R0bV9kZWJ1Z2ZzX2luaXQoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4g ICBzdGF0aWMgdm9pZCByYWRlb25fdHRtX2RlYnVnZnNfZmluaShzdHJ1Y3QgcmFkZW9uX2Rldmlj ZSAqcmRldikKPiAgIHsKPiAgICNpZiBkZWZpbmVkKENPTkZJR19ERUJVR19GUykKPiArCWludCBp Owo+ICAgCj4gLQlkZWJ1Z2ZzX3JlbW92ZShyZGV2LT5tbWFuLnZyYW0pOwo+IC0JcmRldi0+bW1h bi52cmFtID0gTlVMTDsKPiArCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHJhZGVvbl9kZWJ1 Z2ZzX2ZpbGVzKTsgaSsrKSB7Cj4gKwkJc3RydWN0IGRybV9pbmZvX2xpc3QgKmluZm9fbGlzdCA9 Cj4gKwkJCShzdHJ1Y3QgZHJtX2luZm9fbGlzdCAqKSZyYWRlb25fZGVidWdmc19maWxlc1tpXTsK PiAgIAo+IC0JZGVidWdmc19yZW1vdmUocmRldi0+bW1hbi5ndHQpOwo+IC0JcmRldi0+bW1hbi5n dHQgPSBOVUxMOwo+ICsJCWRybV9kZWJ1Z2ZzX3JlbW92ZV9maWxlcyhpbmZvX2xpc3QsIDEsIHJk ZXYtPmRkZXYtPnByaW1hcnkpOwoKVGhpcyB3b24ndCB3b3JrIGNvcnJlY3RseSBiZWNhdXNlIGlu Zm9fZW50IGRvZXNuJ3QgY29udGFpbiB0aGlzIHBvaW50ZXIgCmJ1dCBhIHBvaW50ZXIgdG8gdGhl IGZvcHMgaW5zdGVhZC4gQWRkaXRpb25hbCB0byB0aGF0IHRoZSBmb3BzIG1pZ2h0IG5vdCAKYmUg dW5pcXVlICh5b3UgY2FuIHVzZSB0aGUgc2FtZSBmb3BzIGZvciBkaWZmZXJlbnQgZmlsZXMpIHNv IHRoZXkgYXJlIApwcm9iYWJseSBub3Qgc3VjaCBhIGdvb2QgY2hvaWNlIGFzIHRoZSBrZXkuCgpP biB0aGUgb3RoZXIgaGFuZCB3aHkgZG8gdGhlIGRybSBsYXllciB3YW50IHRvIGRvIHRoaXMgYm9v a2tlZXBpbmcgb2YgCmFsbCB0aGUgY3JlYXRlZCBmaWxlcyBpbiB0aGUgZmlyc3QgcGxhY2U/IFdl IGNvdWxkIGp1c3QgdXNlIApkZWJ1Z2ZzX3JlbW92ZV9yZWN1cnNpdmUgaW5zdGVhZCBhbmQgZG9u J3QgbmVlZCB0byBtZXNzIHdpdGggdGhpcyBhdCBhbGwuCgpSZWdhcmRzLApDaHJpc3RpYW4uCgo+ ICsJfQo+ICAgI2VuZGlmCj4gICB9CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK