From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Wed, 22 Jan 2014 13:46:48 +0100
Subject: [U-Boot] [RFC PATCH 1/2] common: Add new clk command
In-Reply-To: <a80ed6081b2a53afde032ebe288d3984c501860b.1390388559.git.michal.simek@xilinx.com>
References: <a80ed6081b2a53afde032ebe288d3984c501860b.1390388559.git.michal.simek@xilinx.com>
Message-ID: <52DFBDB8.4070606@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Michal,

On 22/01/2014 12:02, Michal Simek wrote:
> Command provides just dump subcommand for showing clock frequencies
> in a soc.
> 

i.MXes has already an own command for this functionality - see command
"clocks" in arch/arm. However, I like that we can have a common
command for all SOCs.


> Signed-off-by: Michal Simek <michal.simek@xilinx.com> ---
> 
> README                   |  1 + common/Makefile          |  1 + 
> common/cmd_clk.c         | 51
> ++++++++++++++++++++++++++++++++++++++++++++++++ include/clk.h
> |  6 ++++++ include/config_cmd_all.h |  1 + 5 files changed, 60
> insertions(+) create mode 100644 common/cmd_clk.c create mode
> 100644 include/clk.h
> 
> diff --git a/README b/README index aea82be..0087649 100644 ---
> a/README +++ b/README @@ -887,6 +887,7 @@ The following options
> need to be configured: CONFIG_CMD_BSP		* Board specific commands 
> CONFIG_CMD_BOOTD	  bootd CONFIG_CMD_CACHE	* icache, dcache +
> CONFIG_CMD_CLK   	* clock command support CONFIG_CMD_CONSOLE
> coninfo CONFIG_CMD_CRC32	* crc32 CONFIG_CMD_DATE		* support for
> RTC, date/time... diff --git a/common/Makefile b/common/Makefile 
> index d12cba5..a000e7d 100644 --- a/common/Makefile +++
> b/common/Makefile @@ -59,6 +59,7 @@ obj-$(CONFIG_CMD_BOOTLDR) +=
> cmd_bootldr.o obj-$(CONFIG_CMD_BOOTSTAGE) += cmd_bootstage.o 
> obj-$(CONFIG_CMD_CACHE) += cmd_cache.o obj-$(CONFIG_CMD_CBFS) +=
> cmd_cbfs.o +obj-$(CONFIG_CMD_CLK) += cmd_clk.o 
> obj-$(CONFIG_CMD_CONSOLE) += cmd_console.o 
> obj-$(CONFIG_CMD_CPLBINFO) += cmd_cplbinfo.o 
> obj-$(CONFIG_DATAFLASH_MMC_SELECT) += cmd_dataflash_mmc_mux.o diff
> --git a/common/cmd_clk.c b/common/cmd_clk.c new file mode 100644 
> index 0000000..6d3d46a --- /dev/null +++ b/common/cmd_clk.c @@ -0,0
> +1,51 @@ +/* + * Copyright (C) 2013 Xilinx, Inc. + * + *
> SPDX-License-Identifier:	GPL-2.0+ + */ +#include <common.h> 
> +#include <command.h> +#include <clk.h> + +int __weak
> soc_clk_dump(void) +{ +	puts("Not implemented\n"); +	return 1; +} 
> + +static int do_clk_dump(cmd_tbl_t *cmdtp, int flag, int argc, +
> char *const argv[]) +{ +	return soc_clk_dump(); +} + +static
> cmd_tbl_t cmd_clk_sub[] = { +	U_BOOT_CMD_MKENT(dump, 1, 1,
> do_clk_dump, "", ""), +}; +

Do you plan to extend the list with new functionalities ? IMHO we
should do it when we really need, that is when we will need at least a
second subcommand.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================