Re: [Qemu-devel] [PATCH] qapi: Add "backing" and "file" to BlockStats

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On 01/22/2014 02:35 AM, Kevin Wolf wrote:
> Am 22.01.2014 um 04:30 hat Fam Zheng geschrieben:
>> Currently there is no way to query BlockStats of the backing chain. This
>> adds "backing" and "file" fields into BlockStats to make it possible.
>>
>> The old optional field "parent", which has the information for "file",
>> is kept there for backward compatibility, as an alias for "file".
>> However field name "file" is more consistent with "file" option name in
>> the block device configuration interface.
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> I don't think it's a good idea to duplicate a field just because we like
> the new name better. Eric?

I concur - duplication for the sake of naming consistency doesn't add
any measurable benefit; I'd rather just improve the docs for the
existing name (libvirt will be forced to use the old name for
back-compat reasons anyway, making the new name useless cruft that just
makes the JSON longer and cost more cycles to parse then discard).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]