All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: [PATCH kvm-kmod]
Date: Wed, 22 Jan 2014 17:29:56 +0100	[thread overview]
Message-ID: <52DFF204.2060402@redhat.com> (raw)

After KVM commit 8a3caa6d74597c2a083f7c87f866891a0b12540b, kvm-kmod
is broken in weird ways (for me it breaks every other time kvm is
loaded, but only with ept=0...).

The reason is that, after this commit, empty_zero_page is expected
to be page-aligned, but the kvm-kmod compatibility shim isn't.
empty_zero_page has been exported since v2.6.25:

commit 8232fd625217dc641ed05dd238a8bb5c82828082
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Mon Nov 26 20:42:19 2007 +0100

    x86: export the symbol empty_zero_page on the 32-bit x86 architecture
    
    The latest KVM driver wants to use the empty_zero_page symbol, and it's
    not exported in 32-bit x86 (although it is exported by x86_64, s390, and
    uml architectures).
    
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Cc: tglx@linutronix.de
    Cc: linux-kernel@vger.kernel.com
    Cc: kvm-devel@lists.sourceforge.net
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

so the compatibility shim should probably just be dropped.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

---


diff --git a/external-module-compat-comm.h b/external-module-compat-comm.h
index 34fb320..580aa9f 100644
--- a/external-module-compat-comm.h
+++ b/external-module-compat-comm.h
@@ -180,18 +180,6 @@ void kvm_smp_send_reschedule(int cpu);
 
 #endif
 
-/* empty_zero_page isn't exported in all kernels */
-#include <asm/pgtable.h>
-
-#define empty_zero_page kvm_empty_zero_page
-
-static char empty_zero_page[PAGE_SIZE];
-
-static inline void blahblah(void)
-{
-	(void)empty_zero_page[0];
-}
-
 /* __mmdrop() is not exported before 2.6.25 */
 #include <linux/sched.h>
 

             reply	other threads:[~2014-01-22 17:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22 16:29 Paolo Bonzini [this message]
2014-01-23  8:08 ` [PATCH kvm-kmod] Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DFF204.2060402@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.