From: Max Reitz <mreitz@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/4] qcow2: fix offset overflow in qcow2_alloc_clusters_at()
Date: Wed, 22 Jan 2014 20:16:44 +0100 [thread overview]
Message-ID: <52E0191C.2070209@redhat.com> (raw)
In-Reply-To: <c1a0ad2294bda973b06f9e323aeed7b11f29c53b.1390373621.git.hutao@cn.fujitsu.com>
On 22.01.2014 07:57, Hu Tao wrote:
> When cluster size is big enough it can lead offset overflow
> in qcow2_alloc_clusters_at(). This patch fixes it.
>
> The allocation each time is stopped at L2 table boundary
> (see handle_alloc()), so the possible maximum bytes could be
>
> 2^(cluster_bits - 3 + cluster_bits)
>
> so int is safe for cluster_bits<=17, unsafe otherwise.
>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
> block/qcow2-refcount.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-01-22 19:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 6:57 [Qemu-devel] [PATCH v3 0/4] qemu-img: fix bugs when cluster size is larger than the default value Hu Tao
2014-01-22 6:57 ` [Qemu-devel] [PATCH v3 1/4] qcow2: remove n_start and n_end of qcow2_alloc_cluster_offset() Hu Tao
2014-01-22 9:56 ` Kevin Wolf
2014-01-23 2:52 ` Hu Tao
2014-01-22 6:57 ` [Qemu-devel] [PATCH v3 2/4] qcow2: fix offset overflow in qcow2_alloc_clusters_at() Hu Tao
2014-01-22 19:16 ` Max Reitz [this message]
2014-01-23 2:53 ` Hu Tao
2014-01-22 6:57 ` [Qemu-devel] [PATCH v3 3/4] qcow2: check for NULL l2meta Hu Tao
2014-01-22 6:57 ` [Qemu-devel] [PATCH v3 4/4] qemu-iotests: add test for qcow2 preallocation with different cluster sizes Hu Tao
2014-01-22 10:02 ` Kevin Wolf
2014-01-23 2:48 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E0191C.2070209@redhat.com \
--to=mreitz@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.