From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: "H. Peter Anvin" <hpa@linux.intel.com>,
David Cohen <david.a.cohen@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
<fengguang.wu@intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Fei Yang <fei.yang@intel.com>
Subject: Re: [PATCH v2] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h
Date: Wed, 22 Jan 2014 17:10:47 -0500 [thread overview]
Message-ID: <52E041E7.4010908@windriver.com> (raw)
In-Reply-To: <52E0404E.4010403@linux.intel.com>
On 14-01-22 05:03 PM, H. Peter Anvin wrote:
> On 01/22/2014 01:50 PM, David Cohen wrote:
>>>
>>> -void * __cpuinit get_penwell_ops()
>>> +void *get_penwell_ops()
>>> {
>>> return &penwell_ops;
>>> }
>>>
>>> -void * __cpuinit get_cloverview_ops()
>>> +void *get_cloverview_ops()
>>> {
>>> return &penwell_ops;
>>> }
>>
>
> Can someone also find and fix the missing (void)s?
Sure, I can do that, if nobody else wants to.
P.
--
>
> -hpa
>
>
next prev parent reply other threads:[~2014-01-22 22:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52dff2dd.pH9hExjpyBbWvw0a%fengguang.wu@intel.com>
2014-01-22 16:59 ` [PATCH] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h Paul Gortmaker
2014-01-22 17:04 ` Paul Gortmaker
2014-01-22 17:34 ` [PATCH v2] " Paul Gortmaker
2014-01-22 18:11 ` David Cohen
2014-01-22 21:50 ` David Cohen
2014-01-22 21:58 ` Paul Gortmaker
2014-01-22 22:13 ` David Cohen
2014-01-22 22:03 ` H. Peter Anvin
2014-01-22 22:10 ` Paul Gortmaker [this message]
2014-01-22 22:19 ` David Cohen
2014-01-22 22:22 ` [PATCH] x86: intel-mid: add missing 'void' to functions without arguments David Cohen
2014-01-22 22:33 ` [tip:x86/intel-mid] x86, intel-mid: Add " tip-bot for David Cohen
2014-01-22 22:24 ` [tip:x86/intel-mid] x86: Don' t introduce more __cpuinit users in intel_mid_weak_decls.h tip-bot for Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E041E7.4010908@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=david.a.cohen@linux.intel.com \
--cc=fei.yang@intel.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.