Re: [Qemu-devel] [PATCH] cpu: implementing victim TLB for QEMU system emulated TLB

[Richard Henderson <rth@twiddle.net>]

On 01/22/2014 02:40 PM, Xin Tong wrote:
> Thank you very much for your comments. I will provide fixes to the
> problems you raised and make sure my next patch passes the
> checkpatch.pl. I have a question I would like to make sure. After i go
> back and fixed the problems with this patch. I need to send another
> (different) email with the title of "[Qemu-devel] [PATCH v2] cpu:
> implementing victim TLB for QEMU system emulated TLB"  and with the
> changes from both of the patches?

Well, "both" patches is a misnomer.  One patch.  The new patch.

The subject does not need to contain [Qemu-devel].  Try

  git format-patch --subject-prefix='PATCH v2' master

from the branch containing your work.  Then use "git send-email" to avoid the
line wrapping you had before.

But otherwise yes.  And if you can get some different benchmarks, something
with more context switches than running a single program, that'd be great.
Peter mentioned an OS boot.  I might suggest a complex shell script.

An example that comes to mind is qemu's own configure script.  Set up a linux
virtual machine with everything to build qemu within the virtual machine.  This
part can be done with -enable-kvm for speed.  Then restart the vm without
-enable-kvm so that we use TCG.  Then you can do something as simple as "time
./configure" to get your number.


r~