All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211:  Extra debug info for station cleanup case.
Date: Wed, 22 Jan 2014 15:58:38 -0800	[thread overview]
Message-ID: <52E05B2E.7030200@candelatech.com> (raw)
In-Reply-To: <1390432284.20070.1.camel@jlt4.sipsolutions.net>

On 01/22/2014 03:11 PM, Johannes Berg wrote:
> On Wed, 2014-01-22 at 14:54 -0800, greearb@candelatech.com wrote:
>> -		WARN_ON_ONCE(ret != 0);
>> +		if (WARN_ON_ONCE(ret != 0))
>> +			sdata_info(sdata, "sta-info-destroy: drv-sta-state error: %i, sta: %pM\n",
>> +				   ret, sta->sta.addr);
> 
> You should put the string into the warning
> 
> WARN_ONCE(ret, "sta-info-destroy: ...", ...)

I wanted it to kernel splat once and print out a message, and after that, only print
messages.

I think your suggestion will only splat _and_ print once?

Thanks,
Ben

> 
> johannes
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2014-01-22 23:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22 22:54 [PATCH 1/2] mac80211: Extra debug info for station cleanup case greearb
2014-01-22 22:54 ` [PATCH 2/2] mac80211: Support tx-hw-crypt with rx-sw-crypt greearb
2014-01-22 23:10   ` Johannes Berg
2014-01-23  0:05     ` Ben Greear
2014-01-23  8:19       ` Johannes Berg
2014-01-23 14:52         ` Ben Greear
2014-01-23 14:55           ` Johannes Berg
2014-01-23 17:26             ` Ben Greear
2014-01-22 23:11 ` [PATCH 1/2] mac80211: Extra debug info for station cleanup case Johannes Berg
2014-01-22 23:58   ` Ben Greear [this message]
2014-01-23  8:20     ` Johannes Berg
2014-01-23 14:44       ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E05B2E.7030200@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.