From: Zhang Min <rudy.zhangmin@huawei.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: kwolf@redhat.com, Fam Zheng <famz@redhat.com>,
"Wangting (Kathy)" <kathy.wangting@huawei.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Qinling <mail.qinling@huawei.com>,
"Chentao (Boby)" <boby.chen@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Wubin (H)" <wu.wubin@huawei.com>
Subject: [Qemu-devel] [PATCH v2] drive mirror:fix memory leak
Date: Thu, 23 Jan 2014 15:59:16 +0800 [thread overview]
Message-ID: <52E0CBD4.5090306@huawei.com> (raw)
In the function mirror_iteration() -> qemu_iovec_init(),
it allocates memory for op->qiov.iov, when the write request calls back,
but in the function mirror_iteration_done(), it only frees the op,
not free the op->qiov.iov, so this causes memory leak.
It should use qemu_iovec_destroy() to free op->qiov.
Signed-off-by: Zhang Min <rudy.zhangmin@huawei.com>
---
block/mirror.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 2932bab..05758e5 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -96,6 +96,7 @@ static void mirror_iteration_done(MirrorOp *op, int ret)
bitmap_set(s->cow_bitmap, chunk_num, nb_chunks);
}
+ qemu_iovec_destroy(&op->qiov);
g_slice_free(MirrorOp, op);
qemu_coroutine_enter(s->common.co, NULL);
}
--
1.7.3.1.msysgit.0
next reply other threads:[~2014-01-23 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 7:59 Zhang Min [this message]
2014-01-23 10:51 ` [Qemu-devel] [PATCH v2] drive mirror:fix memory leak Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E0CBD4.5090306@huawei.com \
--to=rudy.zhangmin@huawei.com \
--cc=boby.chen@huawei.com \
--cc=famz@redhat.com \
--cc=kathy.wangting@huawei.com \
--cc=kwolf@redhat.com \
--cc=mail.qinling@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.