From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Prisk Subject: Re: [PATCH 2/2] clocksource: Make clocksource register functions void Date: Thu, 23 Jan 2014 21:04:40 +1300 Message-ID: <52E0CD18.5080104@prisktech.co.nz> References: <1390461166-36440-1-git-send-email-wangyijing@huawei.com> <52E0C889.6000106@prisktech.co.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Geert Uytterhoeven Cc: Yijing Wang , John Stultz , Thomas Gleixner , Linux MIPS Mailing List , Daniel Lezcano , Kevin Hilman , Benjamin Herrenschmidt , linux , Sekhar Nori , Paul Mackerras , "H. Peter Anvin" , Daniel Walker , Hans-Christian Egtvedt , Jonas Bonn , Kukjin Kim , Russell King , Richard Weinberger , the arch/x86 maintainers , Tony Lindgren , Ingo List-Id: linux-arm-msm@vger.kernel.org On 23/01/14 20:58, Geert Uytterhoeven wrote: > On Thu, Jan 23, 2014 at 8:45 AM, Tony Prisk wrote: >>> -static inline int clocksource_register_hz(struct clocksource *cs, u32 >>> hz) >>> +static inline void clocksource_register_hz(struct clocksource *cs, u32 >>> hz) >>> { >>> return __clocksource_register_scale(cs, 1, hz); >>> } >> >> This doesn't make sense - you are still returning a value on a function >> declared void, and the return is now from a function that doesn't return >> anything either ?!?! >> Doesn't this throw a compile-time warning?? > No, passing on void in functions returning void doesn't cause compiler > warnings. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Doesn't seem right to me (even if there is no warning) but that's probably because I used to program in Pascal where functions with no return were 'procedures' :) Whether it needs to be changed or not: For the vt8500 part - Acked-by: Tony Prisk Regards Tony Prisk From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 23 Jan 2014 09:04:23 +0100 (CET) Received: from server.prisktech.co.nz ([115.188.14.127]:60252 "EHLO server.prisktech.co.nz" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6825733AbaAWIEUl0tV6 (ORCPT ); Thu, 23 Jan 2014 09:04:20 +0100 Received: from [192.168.0.102] (unknown [192.168.0.102]) by server.prisktech.co.nz (Postfix) with ESMTP id 61BD0FC11D4; Thu, 23 Jan 2014 21:04:23 +1300 (NZDT) Message-ID: <52E0CD18.5080104@prisktech.co.nz> Date: Thu, 23 Jan 2014 21:04:40 +1300 From: Tony Prisk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Yijing Wang , John Stultz , Thomas Gleixner , Linux MIPS Mailing List , Daniel Lezcano , Kevin Hilman , Benjamin Herrenschmidt , linux , Sekhar Nori , Paul Mackerras , "H. Peter Anvin" , Daniel Walker , Hans-Christian Egtvedt , Jonas Bonn , Kukjin Kim , Russell King , Richard Weinberger , the arch/x86 maintainers , Tony Lindgren , Ingo Molnar , linux-arm-msm@vger.kernel.org, David Brown , Haavard Skinnemoen , Mike Frysinger , uml-devel , Nicolas Ferre , Jeff Dike , Barry Song , linux-samsung-soc@vger.kernel.org, uml-user , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , davinci-linux-open-source@linux.davincidsp.com, Michal Simek , Jim Cromie , microblaze-uclinux@itee.uq.edu.au, Hanjun Guo , "linux-kernel@vger.kernel.org" , Ralf Baechle , Bryan Huntsman , "uclinux-dist-devel@blackfin.uclinux.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH 2/2] clocksource: Make clocksource register functions void References: <1390461166-36440-1-git-send-email-wangyijing@huawei.com> <52E0C889.6000106@prisktech.co.nz> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 39083 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: linux@prisktech.co.nz Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 23/01/14 20:58, Geert Uytterhoeven wrote: > On Thu, Jan 23, 2014 at 8:45 AM, Tony Prisk wrote: >>> -static inline int clocksource_register_hz(struct clocksource *cs, u32 >>> hz) >>> +static inline void clocksource_register_hz(struct clocksource *cs, u32 >>> hz) >>> { >>> return __clocksource_register_scale(cs, 1, hz); >>> } >> >> This doesn't make sense - you are still returning a value on a function >> declared void, and the return is now from a function that doesn't return >> anything either ?!?! >> Doesn't this throw a compile-time warning?? > No, passing on void in functions returning void doesn't cause compiler > warnings. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Doesn't seem right to me (even if there is no warning) but that's probably because I used to program in Pascal where functions with no return were 'procedures' :) Whether it needs to be changed or not: For the vt8500 part - Acked-by: Tony Prisk Regards Tony Prisk From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from server.prisktech.co.nz (server.prisktech.co.nz [115.188.14.127]) by ozlabs.org (Postfix) with ESMTP id 2606B2C00A5 for ; Thu, 23 Jan 2014 19:04:13 +1100 (EST) Message-ID: <52E0CD18.5080104@prisktech.co.nz> Date: Thu, 23 Jan 2014 21:04:40 +1300 From: Tony Prisk MIME-Version: 1.0 To: Geert Uytterhoeven Subject: Re: [PATCH 2/2] clocksource: Make clocksource register functions void References: <1390461166-36440-1-git-send-email-wangyijing@huawei.com> <52E0C889.6000106@prisktech.co.nz> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Cc: Linux MIPS Mailing List , the arch/x86 maintainers , Kevin Hilman , linux , Sekhar Nori , Michal Simek , Paul Mackerras , Ralf Baechle , "H. Peter Anvin" , Yijing Wang , Daniel Walker , Hans-Christian Egtvedt , Jonas Bonn , Kukjin Kim , Russell King , Richard Weinberger , Daniel Lezcano , Tony Lindgren , Ingo Molnar , microblaze-uclinux@itee.uq.edu.au, David Brown , Haavard Skinnemoen , Mike Frysinger , uml-devel , linux-arm-msm@vger.kernel.org, Jeff Dike , davinci-linux-open-source@linux.davincidsp.com, linux-samsung-soc@vger.kernel.org, John Stultz , uml-user , Thomas Gleixner , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Barry Song , Jim Cromie , Hanjun Guo , "linux-kernel@vger.kernel.org" , Nicolas Ferre , Bryan Huntsman , "uclinux-dist-devel@blackfin.uclinux.org" , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 23/01/14 20:58, Geert Uytterhoeven wrote: > On Thu, Jan 23, 2014 at 8:45 AM, Tony Prisk wrote: >>> -static inline int clocksource_register_hz(struct clocksource *cs, u32 >>> hz) >>> +static inline void clocksource_register_hz(struct clocksource *cs, u32 >>> hz) >>> { >>> return __clocksource_register_scale(cs, 1, hz); >>> } >> >> This doesn't make sense - you are still returning a value on a function >> declared void, and the return is now from a function that doesn't return >> anything either ?!?! >> Doesn't this throw a compile-time warning?? > No, passing on void in functions returning void doesn't cause compiler > warnings. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Doesn't seem right to me (even if there is no warning) but that's probably because I used to program in Pascal where functions with no return were 'procedures' :) Whether it needs to be changed or not: For the vt8500 part - Acked-by: Tony Prisk Regards Tony Prisk From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@prisktech.co.nz (Tony Prisk) Date: Thu, 23 Jan 2014 21:04:40 +1300 Subject: [PATCH 2/2] clocksource: Make clocksource register functions void In-Reply-To: References: <1390461166-36440-1-git-send-email-wangyijing@huawei.com> <52E0C889.6000106@prisktech.co.nz> Message-ID: <52E0CD18.5080104@prisktech.co.nz> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 23/01/14 20:58, Geert Uytterhoeven wrote: > On Thu, Jan 23, 2014 at 8:45 AM, Tony Prisk wrote: >>> -static inline int clocksource_register_hz(struct clocksource *cs, u32 >>> hz) >>> +static inline void clocksource_register_hz(struct clocksource *cs, u32 >>> hz) >>> { >>> return __clocksource_register_scale(cs, 1, hz); >>> } >> >> This doesn't make sense - you are still returning a value on a function >> declared void, and the return is now from a function that doesn't return >> anything either ?!?! >> Doesn't this throw a compile-time warning?? > No, passing on void in functions returning void doesn't cause compiler > warnings. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Doesn't seem right to me (even if there is no warning) but that's probably because I used to program in Pascal where functions with no return were 'procedures' :) Whether it needs to be changed or not: For the vt8500 part - Acked-by: Tony Prisk Regards Tony Prisk