From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Subject: Re: [PATCH 3/6] drm/radeon: Use new drm debugfs file helper Date: Thu, 23 Jan 2014 11:57:41 +0100 Message-ID: <52E0F5A5.4090408@amd.com> References: <1389708847-25038-1-git-send-email-benjamin.widawsky@intel.com> <1390336402-2049-1-git-send-email-benjamin.widawsky@intel.com> <1390336402-2049-3-git-send-email-benjamin.widawsky@intel.com> <52DF993E.6070203@amd.com> <20140123032042.GA2588@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from co1outboundpool.messaging.microsoft.com (co1ehsobe003.messaging.microsoft.com [216.32.180.186]) by gabe.freedesktop.org (Postfix) with ESMTP id 0357DFB882 for ; Thu, 23 Jan 2014 02:57:50 -0800 (PST) In-Reply-To: <20140123032042.GA2588@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Ben Widawsky Cc: DRI Development , Ben Widawsky List-Id: dri-devel@lists.freedesktop.org QW0gMjMuMDEuMjAxNCAwNDoyMCwgc2NocmllYiBCZW4gV2lkYXdza3k6Cj4gT24gV2VkLCBKYW4g MjIsIDIwMTQgYXQgMTE6MTE6MTBBTSArMDEwMCwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPj4g QW0gMjEuMDEuMjAxNCAyMTozMywgc2NocmllYiBCZW4gV2lkYXdza3k6Cj4+PiBUaGUgZGVidWdm cyBoZWxwZXIgZHVwbGljYXRlcyB0aGUgZnVuY3Rpb25hbGl0eSB1c2VkIGJ5IEFybWFkYSwgc28g bGV0J3MKPj4+IGp1c3QgdXNlIHRoYXQuCj4+Pgo+Pj4gV0FSTklORzogb25seSBjb21waWxlIHRl c3RlZAo+Pj4KPj4+IENjOiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5j b20+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBCZW4gV2lkYXdza3kgPGJlbkBid2lkYXdzay5uZXQ+Cj4+ PiAtLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb24uaCAgICAgfCAgNSAtLS0t LQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl90dG0uYyB8IDQzICsrKysrKysr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAyNiBp bnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL3JhZGVvbi9yYWRlb24uaCBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9u LmgKPj4+IGluZGV4IGM1NTE5Y2EuLmNlZWM0NjggMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vcmFkZW9uL3JhZGVvbi5oCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Jh ZGVvbi5oCj4+PiBAQCAtNDE4LDExICs0MTgsNiBAQCBzdHJ1Y3QgcmFkZW9uX21tYW4gewo+Pj4g ICAJc3RydWN0IHR0bV9ib19kZXZpY2UJCWJkZXY7Cj4+PiAgIAlib29sCQkJCW1lbV9nbG9iYWxf cmVmZXJlbmNlZDsKPj4+ICAgCWJvb2wJCQkJaW5pdGlhbGl6ZWQ7Cj4+PiAtCj4+PiAtI2lmIGRl ZmluZWQoQ09ORklHX0RFQlVHX0ZTKQo+Pj4gLQlzdHJ1Y3QgZGVudHJ5CQkJKnZyYW07Cj4+PiAt CXN0cnVjdCBkZW50cnkJCQkqZ3R0Owo+Pj4gLSNlbmRpZgo+Pj4gICB9Owo+Pj4gICAvKiBibyB2 aXJ0dWFsIGFkZHJlc3MgaW4gYSBzcGVjaWZpYyB2bSAqLwo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX3R0bS5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9y YWRlb25fdHRtLmMKPj4+IGluZGV4IDc3ZjViMGMuLmNmN2NhZjIgMTAwNjQ0Cj4+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl90dG0uYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3JhZGVvbi9yYWRlb25fdHRtLmMKPj4+IEBAIC05NzEsMjcgKzk3MSwzNCBAQCBzdGF0aWMg Y29uc3Qgc3RydWN0IGZpbGVfb3BlcmF0aW9ucyByYWRlb25fdHRtX2d0dF9mb3BzID0gewo+Pj4g ICAJLmxsc2VlayA9IGRlZmF1bHRfbGxzZWVrCj4+PiAgIH07Cj4+PiArc3RhdGljIGNvbnN0IHN0 cnVjdCByYWRlb25fZGVidWdmc19maWxlcyB7Cj4+PiArCWNvbnN0IGNoYXIgKm5hbWU7Cj4+PiAr CWNvbnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgKmZvcHM7Cj4+PiArfSByYWRlb25fZGVidWdm c19maWxlc1tdID0gewo+Pj4gKwl7InJhZGVvbl92cmFtIiwgJnJhZGVvbl90dG1fdnJhbV9mb3Bz fSwKPj4+ICsJeyJyYWRlb25fZ3R0IiwgJnJhZGVvbl90dG1fZ3R0X2ZvcHN9LAo+Pj4gK307Cj4+ PiAgICNlbmRpZgo+Pj4gICBzdGF0aWMgaW50IHJhZGVvbl90dG1fZGVidWdmc19pbml0KHN0cnVj dCByYWRlb25fZGV2aWNlICpyZGV2KQo+Pj4gICB7Cj4+PiAgICNpZiBkZWZpbmVkKENPTkZJR19E RUJVR19GUykKPj4+ICAgCXVuc2lnbmVkIGNvdW50Owo+Pj4gKwlpbnQgaSwgcmV0Owo+Pj4gICAJ c3RydWN0IGRybV9taW5vciAqbWlub3IgPSByZGV2LT5kZGV2LT5wcmltYXJ5Owo+Pj4gLQlzdHJ1 Y3QgZGVudHJ5ICplbnQsICpyb290ID0gbWlub3ItPmRlYnVnZnNfcm9vdDsKPj4+IC0KPj4+IC0J ZW50ID0gZGVidWdmc19jcmVhdGVfZmlsZSgicmFkZW9uX3ZyYW0iLCBTX0lGUkVHIHwgU19JUlVH Tywgcm9vdCwKPj4+IC0JCQkJICByZGV2LCAmcmFkZW9uX3R0bV92cmFtX2ZvcHMpOwo+Pj4gLQlp ZiAoSVNfRVJSKGVudCkpCj4+PiAtCQlyZXR1cm4gUFRSX0VSUihlbnQpOwo+Pj4gLQlyZGV2LT5t bWFuLnZyYW0gPSBlbnQ7Cj4+PiAtCj4+PiAtCWVudCA9IGRlYnVnZnNfY3JlYXRlX2ZpbGUoInJh ZGVvbl9ndHQiLCBTX0lGUkVHIHwgU19JUlVHTywgcm9vdCwKPj4+IC0JCQkJICByZGV2LCAmcmFk ZW9uX3R0bV9ndHRfZm9wcyk7Cj4+PiAtCWlmIChJU19FUlIoZW50KSkKPj4+IC0JCXJldHVybiBQ VFJfRVJSKGVudCk7Cj4+PiAtCXJkZXYtPm1tYW4uZ3R0ID0gZW50Owo+Pj4gKwlzdHJ1Y3QgZGVu dHJ5ICpyb290ID0gbWlub3ItPmRlYnVnZnNfcm9vdDsKPj4+ICsKPj4+ICsJZm9yIChpID0gMDsg aSA8IEFSUkFZX1NJWkUocmFkZW9uX2RlYnVnZnNfZmlsZXMpOyBpKyspIHsKPj4+ICsJCXJldCA9 IGRybV9kZWJ1Z2ZzX2NyZWF0ZV9maWxlKHJvb3QsIG1pbm9yLAo+Pj4gKwkJCQkJICAgICAgcmFk ZW9uX2RlYnVnZnNfZmlsZXNbaV0ubmFtZSwKPj4+ICsJCQkJCSAgICAgIHJhZGVvbl9kZWJ1Z2Zz X2ZpbGVzW2ldLmZvcHMsCj4+PiArCQkJCQkgICAgICBTX0lGUkVHIHwgU19JV1VTUik7Cj4+PiAr CQlpZiAocmV0KSB7Cj4+PiArCQkJcmFkZW9uX3R0bV9kZWJ1Z2ZzX2ZpbmkocmRldik7Cj4+PiAr CQkJcmV0dXJuIHJldDsKPj4+ICsJCX0KPj4+ICsJfQo+Pj4gICAJY291bnQgPSBBUlJBWV9TSVpF KHJhZGVvbl90dG1fZGVidWdmc19saXN0KTsKPj4+IEBAIC0xMDEwLDExICsxMDE3LDEzIEBAIHN0 YXRpYyBpbnQgcmFkZW9uX3R0bV9kZWJ1Z2ZzX2luaXQoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJk ZXYpCj4+PiAgIHN0YXRpYyB2b2lkIHJhZGVvbl90dG1fZGVidWdmc19maW5pKHN0cnVjdCByYWRl b25fZGV2aWNlICpyZGV2KQo+Pj4gICB7Cj4+PiAgICNpZiBkZWZpbmVkKENPTkZJR19ERUJVR19G UykKPj4+ICsJaW50IGk7Cj4+PiAtCWRlYnVnZnNfcmVtb3ZlKHJkZXYtPm1tYW4udnJhbSk7Cj4+ PiAtCXJkZXYtPm1tYW4udnJhbSA9IE5VTEw7Cj4+PiArCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9T SVpFKHJhZGVvbl9kZWJ1Z2ZzX2ZpbGVzKTsgaSsrKSB7Cj4+PiArCQlzdHJ1Y3QgZHJtX2luZm9f bGlzdCAqaW5mb19saXN0ID0KPj4+ICsJCQkoc3RydWN0IGRybV9pbmZvX2xpc3QgKikmcmFkZW9u X2RlYnVnZnNfZmlsZXNbaV07Cj4+PiAtCWRlYnVnZnNfcmVtb3ZlKHJkZXYtPm1tYW4uZ3R0KTsK Pj4+IC0JcmRldi0+bW1hbi5ndHQgPSBOVUxMOwo+Pj4gKwkJZHJtX2RlYnVnZnNfcmVtb3ZlX2Zp bGVzKGluZm9fbGlzdCwgMSwgcmRldi0+ZGRldi0+cHJpbWFyeSk7Cj4+IFRoaXMgd29uJ3Qgd29y ayBjb3JyZWN0bHkgYmVjYXVzZSBpbmZvX2VudCBkb2Vzbid0IGNvbnRhaW4gdGhpcyBwb2ludGVy IGJ1dAo+PiBhIHBvaW50ZXIgdG8gdGhlIGZvcHMgaW5zdGVhZC4KPiBZb3UgYXJlIGNvcnJlY3Qu IEl0IHNob3VsZCBoYXZlIGJlZW4gJnJhZGVvbl9kZWJ1Z2ZzX2ZpbGVzW2ldLmZvcHMuCj4KPj4g QWRkaXRpb25hbCB0byB0aGF0IHRoZSBmb3BzIG1pZ2h0IG5vdCBiZSB1bmlxdWUgKHlvdSBjYW4g dXNlIHRoZSBzYW1lCj4+IGZvcHMgZm9yIGRpZmZlcmVudCBmaWxlcykgc28gdGhleSBhcmUgcHJv YmFibHkgbm90IHN1Y2ggYSBnb29kIGNob2ljZQo+PiBhcyB0aGUga2V5Lgo+IFRoaXMgaXMgY29y cmVjdCwgYW5kIEkgZWxhYm9yYXRlIGEgYml0IG9uIHRoaXMgaW4gYSBsYXRlciBwYXRjaCAob3IK PiBlYXJsaWVyLCBJIGZvcmdldCkuIEVzc2VudGlhbGx5IHdlIGhhdmUgZXhhY3RseSBvbmUgdXNh Z2UgKGFmYWljdCkgb2YgYQo+IGNhbGxlciB0aGF0IHdhbnRzIGEgZm9wcyAhPSBrZXkuIEkgZGlk bid0IHdhbnQgdG8gY3JlYXRlIHRoZSBpbnRlcmZhY2UKPiBhcm91bmQgdGhpcyBwb3NzaWJpbGl0 eSwgYnV0IHJhdGhlciBsZXQgb3RoZXIgZXh0ZW5kIGl0IHdoZW4gaXQgYmVjb21lcwo+IG1vcmUg Y29tbW9uLgo+Cj4gSG93ZXZlciwgaWYgdGhpcyBpcyByZXF1ZXN0ZWQvcmVxdWlyZWQsIHdoYXQg SSB3b3VsZCBkbyBpcyBwcm92aWRlIGEKPiB2b2lkICprZXkgYXJndW1lbnQsIHdoZXJlIGEgTlVM TCB2YWx1ZSB3aWxsIHJlc3VsdCBpbiB1c2luZyBmb3BzLgo+Cj4KPj4gT24gdGhlIG90aGVyIGhh bmQgd2h5IGRvIHRoZSBkcm0gbGF5ZXIgd2FudCB0byBkbyB0aGlzIGJvb2trZWVwaW5nIG9mCj4+ IGFsbCB0aGUgY3JlYXRlZCBmaWxlcyBpbiB0aGUgZmlyc3QgcGxhY2U/IFdlIGNvdWxkIGp1c3Qg dXNlCj4+IGRlYnVnZnNfcmVtb3ZlX3JlY3Vyc2l2ZSBpbnN0ZWFkIGFuZCBkb24ndCBuZWVkIHRv IG1lc3Mgd2l0aCB0aGlzIGF0Cj4+IGFsbC4KPj4KPj4gUmVnYXJkcywgQ2hyaXN0aWFuLgo+Pgo+ IFRoZSBhbnN3ZXIgdG8gdGhlIHF1ZXN0aW9uIHByZWRhdGVzIG1lLiBJIHRoaW5rIGhhdmluZyB0 aGUgaGVscGVycyBmb3IKPiB0aGUgY29tbW9uIGNhc2UsIHdoZXJlIHlvdSBvbmx5IHdhbnQgYSBz aG93KCkgZnVuY3Rpb24gaXMgaGFuZHkuIFRoZQo+IGRlY2lzaW9uIHRvIHNwbGl0IG9mZiBhbmQg Y29udGludWUgdG8gc2hvZWhvcm4gbmV3ZXIsIG1vcmUgZmVhdHVyZWQKPiBkZWJ1Z2ZzIGZpbGVz IChhcyB5b3UgaGF2ZSBkb25lIGluIFJhZGVvbiB3aXRoIHRoZXNlIHR3bywgYW5kIGFzIHdlIGhh dmUKPiBkb25lIGluIGk5MTUgYWxsIG92ZXIpIHdhcyBub3Qgb25lIEkgbWFkZSwgbm9yIG9uZSBJ IHJlYWxseSBjYXJlIHRvIGZpeC4KPgo+IFNvIGFzc3VtaW5nIEkgZml4IHRoZSBidWcsIHdoYXQg ZG8geW91IHdhbnQgdG8gbWUgZG8/CgpJZiB5b3Ugd2FudCB0byBjbGVhbiBpdCB1cCB0aGVuIGNs ZWFuIGl0IHVwIGNvbXBsZXRlbHkuCgpUaGUgaGVscGVyIHRvIGFkZCBhIGRlYnVnZnMgZmlsZSB3 aXRoIG9ubHkgYSBzaG93IGZ1bmN0aW9uIHNob3VsZCAKcHJvYmFibHkgYmUgYSBnZW5lcmFsIGRl YnVnZnMgZmVhdHVyZSBpbnN0ZWFkIG9mIGJlaW5nIHBhcnQgb2YgRFJNLgoKU28gYXMgbG9uZyBh cyBub2JvZHkgY2FuIGNvbWUgdXAgd2l0aCBhIGdvb2QgcmVhc29uIHdoeSBEUk0gZG9lcyB0aGlz IApob3VzZWtlZXBpbmcgb2YgYWxsIGNyZWF0ZWQgZGVidWdmcyBmaWxlIEkgd291bGQgc2F5IHVz ZSAKZGVidWdmc19yZW1vdmVfcmVjdXJzaXZlIGluc3RlYWQgYW5kIGtpbGwgdGhlIGNvbXBsZXRl IGRybSBkZWJ1Z2ZzIGhlbHBlcnMuCgpDaHJpc3RpYW4uCgo+Cj4+PiArCX0gI2VuZGlmIH0KPj4K CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=