From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6K4h-0002Vp-Bd for qemu-devel@nongnu.org; Thu, 23 Jan 2014 08:12:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6K4b-0006yK-3T for qemu-devel@nongnu.org; Thu, 23 Jan 2014 08:12:03 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38757 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6K4a-0006yD-Sg for qemu-devel@nongnu.org; Thu, 23 Jan 2014 08:11:57 -0500 Message-ID: <52E11519.3020706@suse.de> Date: Thu, 23 Jan 2014 14:11:53 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <878613f2f12d4162f12629522fd99de8df904856.1390176489.git.alistair.francis@xilinx.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH arm-midr v3 1/2] ARM: Convert MIDR to a property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: Peter Maydell , Peter Crosthwaite , "qemu-devel@nongnu.org Developers" Am 23.01.2014 14:08, schrieb Peter Crosthwaite: > On Mon, Jan 20, 2014 at 10:09 AM, Alistair Francis > wrote: >> Convert the MIDR register to a property. This allows boards to later s= et >> a custom MIDR value. This has been done in such a way to maintain >> compatibility with all existing CPUs and boards >> >> Signed-off-by: Alistair Francis Please use consistent subject prefixes as seen in Git history, in this case "target-arm", not "ARM". Andreas >=20 > Reviewed-by: Peter Crosthwaite >=20 >> --- >> I originally added the properties to the cpu->midr variable in a simil= ar >> method to how Peter Crosthwaite did in his 'Fix Support for ARM CBAR a= nd >> reset-hivecs' series. >> V3: Removed the initialisation of the MIDR property from arm_cpu_post_= init >> as it is no longer needed >> V2: Use dc->props to avoid using qdev_* >> >> target-arm/cpu.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/target-arm/cpu.c b/target-arm/cpu.c >> index 52efd5d..45ad7f0 100644 >> --- a/target-arm/cpu.c >> +++ b/target-arm/cpu.c >> @@ -982,6 +982,7 @@ static const ARMCPUInfo arm_cpus[] =3D { >> >> static Property arm_cpu_properties[] =3D { >> DEFINE_PROP_BOOL("start-powered-off", ARMCPU, start_powered_off, = false), >> + DEFINE_PROP_UINT32("midr", ARMCPU, midr, 0), >> DEFINE_PROP_END_OF_LIST() >> }; >> >> -- >> 1.7.1 >> >> --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg